[chore] Fixing Prom Compliance tests #35071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MovieStoreGuy
added
the
Skip Changelog
MovieStoreGuy
changed the title
MovieStoreGuy
force-pushed
the
msg/chore-ensure-directory
branch
from
0c5bb5e
to
c4ffd31
Compare
Ensuring that the prom compliance checks are being run correctly with the most recent changes
MovieStoreGuy
force-pushed
the
msg/chore-ensure-directory
branch
from
c4ffd31
to
1eb3817
Compare
|
Okay, this should fix the test being run correctly and set up. However, it is failing one of the test cases for counters. |
MovieStoreGuy
commented
Sep 9, 2024
| run: mkdir compliance/remote_write_sender/bin && cp opentelemetry-collector-contrib/bin/otelcontribcol_linux_amd64 compliance/remote_write_sender/bin/otelcol_0.42.0_linux_amd64 | ||
| run: mkdir compliance/remotewrite/sender/bin && cp opentelemetry-collector-contrib/bin/otelcontribcol_linux_amd64 compliance/remotewrite/sender/bin/otelcol_0.42.0_linux_amd64 | ||
| - name: clean up mod file | ||
| run: go mod tidy |
There was a problem hiding this comment.
Not exactly sure why, but when running in the CI it required mod changes. When running locally it look like toolchain changes.
atoulme
approved these changes
Sep 10, 2024
|
#35119 to track the failed test |
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
**Description:** Ensuring prom tests directory is created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ensuring prom tests directory is created.