Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Fixing Prom Compliance tests #35071

Merged
merged 2 commits into from
Sep 10, 2024
Merged

[chore] Fixing Prom Compliance tests #35071

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eb3817
[chore] Ensuring directory is created
MovieStoreGuy Sep 9, 2024
d5c5b14
Merge branch 'main' into msg/chore-ensure-directory
MovieStoreGuy Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/prometheus-compliance-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,12 @@ jobs:
- name: Copy binary to compliance directory
# The required name of the downloaded artifact is `otelcol_0.42.0_linux_amd64`, so we place the collector contrib artifact under the same name in the bin folder to run.
# Source: https://github.com/prometheus/compliance/blob/12cbdf92abf7737531871ab7620a2de965fc5382/remote_write_sender/targets/otel.go#L8
run: mkdir compliance/remote_write_sender/bin && cp opentelemetry-collector-contrib/bin/otelcontribcol_linux_amd64 compliance/remote_write_sender/bin/otelcol_0.42.0_linux_amd64
run: mkdir compliance/remotewrite/sender/bin && cp opentelemetry-collector-contrib/bin/otelcontribcol_linux_amd64 compliance/remotewrite/sender/bin/otelcol_0.42.0_linux_amd64
- name: clean up mod file
run: go mod tidy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly sure why, but when running in the CI it required mod changes. When running locally it look like toolchain changes.

working-directory: compliance/remotewrite/sender
- name: Run compliance tests
run: go test -v --tags=compliance -run "TestRemoteWrite/otel/.+" ./ |& tee ./test-report.txt
working-directory: compliance/remote_write_sender
run: |
set -o pipefail && \
go test -v --tags=compliance -run "TestRemoteWrite/otel/.+" ./ |& tee ./test-report.txt
working-directory: compliance/remotewrite/sender
Loading