You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
If a zipkin span is sent with a zero duration or without the duration set, the zipkin receiver does not set the end time on the span. This bug was introduced in #1446
With the endtime unset, this causes errors in other processors that may look at the span duration as they may do end - start to compute the duration, resulting in a large negative duration.
Steps to reproduce
Post a span to the collector like this
* Update SamplingParameters
Remove HasRemoteParent fields from SamplingParameters. The
HasRemoteParent field is a duplicate of the Remote field of the parent
span context contained in the ParentContext.
Change the `ParentContext` field from storing a `SpanContext` to a
`context.Context` that holds the parent span. This is to conform with
the OpenTelemetry specification and resolveopen-telemetry#1727.
* Update PR number
Describe the bug
If a zipkin span is sent with a zero duration or without the duration set, the zipkin receiver does not set the end time on the span. This bug was introduced in #1446
With the endtime unset, this causes errors in other processors that may look at the span duration as they may do
end - start
to compute the duration, resulting in a large negative duration.Steps to reproduce
Post a span to the collector like this
or like this
What did you expect to see?
The endtime should be set to the starttime
What did you see instead?
endtime is the default value
0
What version did you use?
Version:
8e5c6065eb0e07e9f4d01552de22acccf174a41a
Additional context
I believe the fix should be to return to the previous implementation
https://github.com/open-telemetry/opentelemetry-collector/blob/master/translator/trace/zipkin/zipkinv2_to_traces.go#L169-L171
The text was updated successfully, but these errors were encountered: