Zipkin Receiver: Always set the endtime #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-smith-zocdoc
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
chris-smith-zocdoc
force-pushed
the
issue_1749
branch
from
86adda0
to
fa69d8c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1750 +/- ##
==========================================
+ Coverage 92.39% 92.40% +0.01%
==========================================
Files 256 256
Lines 18190 18189 -1
==========================================
+ Hits 16806 16807 +1
+ Misses 970 969 -1
+ Partials 414 413 -1
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Sep 8, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Adjust TestRecording fucntion to validate with and without sampling. correct span.isRecording logic to return false when not being sampled * Changed to TestExectutionTracerTaskEnd to only expect 1 span to increment instead of all 3 * added changelog entry * Updated CHANGELOG.md * Remove newline from isRecording() * Rewrite TestSpanIsRecording to include table based tests and check for when span is ended immediately * Update sdk/trace/trace_test.go Improve readability of test name Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * Update sdk/trace/trace_test.go Improve readability of test name Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update sdk/trace_test.go test comments Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #1749 allowing the zipkin span duration to be zero