Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configtelemetry] Mark module as stable #11002

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Aug 29, 2024

Description

Fixes #10277

Depends on #10912

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (7da6b61) to head (b0d5dda).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11002   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files         412      412           
  Lines       19313    19313           
=======================================
  Hits        17774    17774           
  Misses       1185     1185           
  Partials      354      354           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after dependency is solved.

@mx-psi mx-psi marked this pull request as ready for review August 30, 2024 07:32
@mx-psi mx-psi requested review from a team and songy23 August 30, 2024 07:32
@mx-psi
Copy link
Member Author

mx-psi commented Aug 30, 2024

cc @open-telemetry/collector-approvers I believe this is ready to merge!

@mx-psi mx-psi added the release:blocker The issue must be resolved before cutting the next release label Aug 30, 2024
@mx-psi mx-psi merged commit b4fab2b into open-telemetry:main Aug 30, 2024
64 of 66 checks passed
@mx-psi mx-psi deleted the mx-psi/configtelemetry-1.0 branch August 30, 2024 14:43
@github-actions github-actions bot added this to the next release milestone Aug 30, 2024
@bogdandrutu
Copy link
Member

Personal opinion, I would try first to completely remove this module instead of making it stable. Why?

  • Otel doesn't have a concept of telemetry level and us in otel-collector inventing this is not the right thing.
  • This concept was added to control "expensive" telemetry (more exactly only metrics), but that can be now controlled with views.

@mx-psi
Copy link
Member Author

mx-psi commented Sep 2, 2024

This concept was added to control "expensive" telemetry (more exactly only metrics), but that can be now controlled with views.

This feels like a way of how to implement the level (each level corresponds to a set of views), but not an argument to remove the level. We have discussed this explicitly and the conclusion was that views alone would be complex for users to interact with

bogdandrutu added a commit that referenced this pull request Sep 4, 2024
codeboten pushed a commit that referenced this pull request Sep 9, 2024
Reverts #11002

Per discussion today 09/04 we will postpone the stabilization of this
module until we have a good understanding of where this will exactly be
used. The decision was that level will not be used in the component, so
stabilization of this model no longer blocks progress on component
module stabilization.
dmathieu pushed a commit to dmathieu/opentelemetry-collector that referenced this pull request Sep 10, 2024
Reverts open-telemetry#11002

Per discussion today 09/04 we will postpone the stabilization of this
module until we have a good understanding of where this will exactly be
used. The decision was that level will not be used in the component, so
stabilization of this model no longer blocks progress on component
module stabilization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize module go.opentelemetry.io/collector/config/configtelemetry
6 participants