-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[configtelemetry] Mark module as stable #11002
[configtelemetry] Mark module as stable #11002
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11002 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 412 412
Lines 19313 19313
=======================================
Hits 17774 17774
Misses 1185 1185
Partials 354 354 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved after dependency is solved.
cc @open-telemetry/collector-approvers I believe this is ready to merge! |
Personal opinion, I would try first to completely remove this module instead of making it stable. Why?
|
This feels like a way of how to implement the level (each level corresponds to a set of views), but not an argument to remove the level. We have discussed this explicitly and the conclusion was that views alone would be complex for users to interact with |
This reverts commit b4fab2b.
Reverts #11002 Per discussion today 09/04 we will postpone the stabilization of this module until we have a good understanding of where this will exactly be used. The decision was that level will not be used in the component, so stabilization of this model no longer blocks progress on component module stabilization.
Reverts open-telemetry#11002 Per discussion today 09/04 we will postpone the stabilization of this module until we have a good understanding of where this will exactly be used. The decision was that level will not be used in the component, so stabilization of this model no longer blocks progress on component module stabilization.
Description
Fixes #10277
Depends on #10912