-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[configtelemetry] Mark module as stable" #11055
Conversation
This reverts commit b4fab2b.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11055 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 405 405
Lines 19089 19089
=======================================
Hits 17606 17606
Misses 1123 1123
Partials 360 360 ☔ View full report in Codecov by Sentry. |
Since we are going to use this for sure in the debug exporter, I mentioned on #11027 (comment) that we should just move forward with this. Is that not the case? |
@mx-psi if we end up using only there, then I would move it to that module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok to revert, this is currently used in the debug exporter, and in service config for both metrics and traces.
Reverts open-telemetry#11002 Per discussion today 09/04 we will postpone the stabilization of this module until we have a good understanding of where this will exactly be used. The decision was that level will not be used in the component, so stabilization of this model no longer blocks progress on component module stabilization.
Reverts #11002
Per discussion today 09/04 we will postpone the stabilization of this module until we have a good understanding of where this will exactly be used. The decision was that level will not be used in the component, so stabilization of this model no longer blocks progress on component module stabilization.