Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[configtelemetry] Mark module as stable" #11055

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Sep 4, 2024

Reverts #11002

Per discussion today 09/04 we will postpone the stabilization of this module until we have a good understanding of where this will exactly be used. The decision was that level will not be used in the component, so stabilization of this model no longer blocks progress on component module stabilization.

@bogdandrutu bogdandrutu requested review from a team and evan-bradley September 4, 2024 20:36
@bogdandrutu bogdandrutu added release:blocker The issue must be resolved before cutting the next release Skip Changelog PRs that do not require a CHANGELOG.md entry labels Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (060d883) to head (ae34886).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11055   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         405      405           
  Lines       19089    19089           
=======================================
  Hits        17606    17606           
  Misses       1123     1123           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi
Copy link
Member

mx-psi commented Sep 4, 2024

Since we are going to use this for sure in the debug exporter, I mentioned on #11027 (comment) that we should just move forward with this. Is that not the case?

@bogdandrutu
Copy link
Member Author

@mx-psi if we end up using only there, then I would move it to that module.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to revert, this is currently used in the debug exporter, and in service config for both metrics and traces.

@codeboten codeboten merged commit 6928951 into main Sep 9, 2024
52 of 83 checks passed
@codeboten codeboten deleted the revert-11002-mx-psi/configtelemetry-1.0 branch September 9, 2024 15:31
@github-actions github-actions bot added this to the next release milestone Sep 9, 2024
dmathieu pushed a commit to dmathieu/opentelemetry-collector that referenced this pull request Sep 10, 2024
Reverts open-telemetry#11002

Per discussion today 09/04 we will postpone the stabilization of this
module until we have a good understanding of where this will exactly be
used. The decision was that level will not be used in the component, so
stabilization of this model no longer blocks progress on component
module stabilization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants