Skip to content

Commit

Permalink
[chore] Fix dependabot-check Make target (#323)
Browse files Browse the repository at this point in the history
* Fix verify exit code in Makefile

The recipe for dependabot-check is not exiting with the correct status
code if the dbotconf verify fails.

* Add chlog

* Delete fix-verify-exit-code.yaml

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
  • Loading branch information
CharlieTLe and pellared committed May 25, 2023
1 parent 6fd2bd7 commit 5373171
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
9 changes: 9 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,15 @@ updates:
schedule:
interval: weekly
day: sunday
- package-ecosystem: gomod
directory: /gotmpl
labels:
- dependencies
- go
- Skip Changelog
schedule:
interval: weekly
day: sunday
- package-ecosystem: gomod
directory: /internal/tools
labels:
Expand Down
3 changes: 1 addition & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ license-check:
DEPENDABOT_CONFIG = .github/dependabot.yml
.PHONY: dependabot-check
dependabot-check: | $(DBOTCONF)
@$(DBOTCONF) verify $(DEPENDABOT_CONFIG) || echo "(run: make dependabot-generate)"
@$(DBOTCONF) verify $(DEPENDABOT_CONFIG) || (echo "Please run 'make dependabot-generate' to update the config" && exit 1)

.PHONY: dependabot-generate
dependabot-generate: | $(DBOTCONF)
Expand Down Expand Up @@ -212,4 +212,3 @@ crosslink: | $(CROSSLINK)
.PHONY: gowork
gowork: | $(CROSSLINK)
$(CROSSLINK) work --root=$(shell pwd)

0 comments on commit 5373171

Please sign in to comment.