Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix dependabot-check Make target #323

Merged
merged 3 commits into from
May 25, 2023

Conversation

CharlieTLe
Copy link
Contributor

@CharlieTLe CharlieTLe commented May 24, 2023

The recipe for dependabot-check is not exiting with the correct status code if the dbotconf verify fails.

cc: @pellared @MrAlias

Fixes #321

The recipe for dependabot-check is not exiting with the correct status
code if the dbotconf verify fails.
@CharlieTLe CharlieTLe requested review from a team and mx-psi May 24, 2023 23:56
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6fd2bd7) 60.22% compared to head (9a50a4f) 60.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage   60.22%   60.22%           
=======================================
  Files          47       47           
  Lines        2172     2172           
=======================================
  Hits         1308     1308           
  Misses        721      721           
  Partials      143      143           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pellared pellared changed the title Fix verify exit code in Makefile [chore] Fix dependabot-check Make target May 25, 2023
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the changelog update and changed the PR title so that the changelog entry is not needed.

@pellared
Copy link
Member

@songy23 PTAL

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrAlias MrAlias merged commit 5373171 into open-telemetry:main May 25, 2023
@CharlieTLe
Copy link
Contributor Author

Thanks @MrAlias @pellared @songy23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbconf verify is not working
4 participants