Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all logging statements from slf4j to jul #5077

Closed
trask opened this issue Jan 11, 2022 · 0 comments · Fixed by #5674
Closed

Convert all logging statements from slf4j to jul #5077

trask opened this issue Jan 11, 2022 · 0 comments · Fixed by #5674
Labels
enhancement New feature or request

Comments

@trask
Copy link
Member

trask commented Jan 11, 2022

Discussed in #5053

  • we should use jul in the instrumentation-api and library instrumentation to be consistent with SDK and limit dependencies
  • we should use jul in javaagent instrumentation because using two different logging libraries feels icky

For now at least, the javaagent will continue to shade all jul usage to PatchLogger.java (which will still use slf4j/slf4jsimple under the hood) for the reasons @laurit mentioned above #5053 (comment), and we will explore redirecting logging to user application logging separately in #5059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert all logging statements from slf4j to jul mateuszrzeszutek/opentelemetry-java-instrumentation
1 participant
@trask