Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all logging statements from slf4j to jul - part 1 #5628

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Convert all logging statements from slf4j to jul - part 1 #5628

merged 4 commits into from
Mar 22, 2022

Conversation

mateuszrzeszutek
Copy link
Member

Half of #5077

Not included in this PR:

  • tooling, muzzle -- will do that in the next PR
  • testing modules -- as far as I understand, we'll probably want to keep using slf4j here; in many tests, we're using testcontainers' built-in facilities to redirect container logs to slf4j logger

@mateuszrzeszutek mateuszrzeszutek requested a review from a team March 18, 2022 14:17
trask
trask reviewed Mar 21, 2022
View reviewed changes
.../src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpServerMetrics.java Outdated Show resolved Hide resolved
...pi/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcClientMetrics.java Outdated Show resolved Hide resolved
...api/src/main/java/io/opentelemetry/instrumentation/api/internal/ContextPropagationDebug.java Outdated Show resolved Hide resolved
...ava/io/opentelemetry/instrumentation/awslambdacore/v1_0/internal/ApiGatewayProxyRequest.java Outdated Show resolved Hide resolved
...ntelemetry/javaagent/instrumentation/internal/classloader/BootDelegationInstrumentation.java Show resolved Hide resolved
...orter/src/main/java/io/opentelemetry/javaagent/testing/exporter/OtlpInMemoryLogExporter.java Outdated Show resolved Hide resolved
...rter/src/main/java/io/opentelemetry/javaagent/testing/exporter/OtlpInMemorySpanExporter.java Outdated Show resolved Hide resolved
...api/src/main/java/io/opentelemetry/instrumentation/api/internal/ContextPropagationDebug.java Outdated Show resolved Hide resolved
...pi/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcServerMetrics.java Outdated Show resolved Hide resolved
...elemetry/instrumentation/jetty/httpclient/v9_2/internal/JettyClientHttpAttributesGetter.java Outdated Show resolved Hide resolved
trask
trask approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 👍

@trask trask merged commit 56f65e4 into open-telemetry:main Mar 22, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@RashmiRam
Convert all logging statements from slf4j to jul - part 1 (open-telem…
8f7e3bb 
…etry#5628)

* Convert all logging statements from slf4j to jul - part 1

* fix tests

* use placeholders

* fixed all comments, added static imports for Level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateuszrzeszutek @trask