Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capability to bridge agent logging into users app logging #5059

Closed
trask opened this issue Jan 9, 2022 · 0 comments · Fixed by #7339
Closed

Capability to bridge agent logging into users app logging #5059

trask opened this issue Jan 9, 2022 · 0 comments · Fixed by #7339
Assignees
@mateuszrzeszutek
Labels
enhancement New feature or request

Comments

@trask
Copy link
Member

trask commented Jan 9, 2022

This has come up a couple of times now inside of other issues:

so creating this standalone issue to track.
@trask trask added the enhancement New feature or request label Jan 9, 2022
This was referenced Jan 11, 2022
Closed
Closed
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Jul 4, 2022
Closed
@mateuszrzeszutek mateuszrzeszutek self-assigned this Nov 23, 2022
This was referenced Nov 23, 2022
Closed
Merged
mateuszrzeszutek pushed a commit that referenced this issue Apr 4, 2023
Bridge agent logs into application's slf4j logger (#7339)
04f2e3e 
Related discussion #7257
Resolves #3413
Resolves #5059
Resolves #6258
Resolves #7179

Adds a logging implementation that'll collect agent logs in memory until
slf4j is detected in the instrumented application; and when that happens
will dump all the logs into the application slf4j and log directly to
the application logger from that time on.

It's still in a POC state, unfortunately: while it works fine with an
app that uses & initializes slf4j directly, Spring Boot applications
actually reconfigure the logging implementation (e.g. logback) a while
after slf4j is loaded; which causes all the startup agent logs (debug
included) to be dumped with the default logback pattern.

Future work:
* ~~Make sure all logs produces by the agent are sent to loggers named
`io.opentelemetry...`
(#7446
DONE
* Make this work on Spring Boot
* Documentation
* Smoke test?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mateuszrzeszutek mateuszrzeszutek

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@trask @mateuszrzeszutek