Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muzzle logs should be logged using the io.opentelemetry.* logger name #7446

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

mateuszrzeszutek
Copy link
Member

Also, log them on DEBUG when debug mode is off.
Related to #7339

@mateuszrzeszutek mateuszrzeszutek requested a review from a team December 19, 2022 10:22
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, log them on DEBUG when debug mode is off.

👍

@trask trask merged commit bb7a12d into open-telemetry:main Jan 12, 2023
@mateuszrzeszutek mateuszrzeszutek deleted the muzzle-logging branch January 12, 2023 09:29
mateuszrzeszutek pushed a commit that referenced this pull request Apr 4, 2023
Related discussion #7257
Resolves #3413
Resolves #5059
Resolves #6258
Resolves #7179

Adds a logging implementation that'll collect agent logs in memory until
slf4j is detected in the instrumented application; and when that happens
will dump all the logs into the application slf4j and log directly to
the application logger from that time on.

It's still in a POC state, unfortunately: while it works fine with an
app that uses & initializes slf4j directly, Spring Boot applications
actually reconfigure the logging implementation (e.g. logback) a while
after slf4j is loaded; which causes all the startup agent logs (debug
included) to be dumped with the default logback pattern.

Future work:
* ~~Make sure all logs produces by the agent are sent to loggers named
`io.opentelemetry...`
(#7446
DONE
* Make this work on Spring Boot
* Documentation
* Smoke test?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants