Django span names according to convention #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Masters sync
aabmass
reviewed
Aug 17, 2020
.../opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py
Outdated
Show resolved
Hide resolved
.../opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-django/CHANGELOG.md
Outdated
Show resolved
Hide resolved
codeboten
added
the
instrumentation
codeboten
approved these changes
Sep 21, 2020
lzchen
approved these changes
Sep 21, 2020
alertedsnake
pushed a commit
to alertedsnake/opentelemetry-python
that referenced
this pull request
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed span name extracting method to comply with convention. Besides the inconsistency, the current method had a flaw that could name different handlers with the same name. For example
api.v1.cities.mainandapi.v2.cities.mainwill have the same namemain. There is a case for older versions of django below version 2.2, when it was impossible to get the url pattern. In this case, the full name of the function will be used, indicating the module where this function is located. This will resolve the issue of collisions of the same function names. Changedprocess_viewtoprocess_requestasprocess_viewargument
view_funcnot required anymoreType of change
How Has This Been Tested?
Added 2 unit tests for span names and fixed all other tests