Sync #1
Merged
Sync #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many times, configuration values are just boolean values. The Configuration object now only returns the literal configuration value. It would be useful to have this object return True instead of "True" to keep code a bit shorter
- Implemented BaseInstrumentor interface to enable auto-instrumentation - Added integration tests (same tests as other db integrations)
#658) There are some examples that are duplicated in the getting started guide and in the examples folder itself. This commit removes the duplicated examples and updates the getting started guide to include then from real source files that are passed through the linter and have tests. Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com> Co-authored-by: alrex <aboten@lightstep.com>
Some build time improvements: - split lint/docker-tests/docs into their own steps. Since lint is usually the thing that fails anyways, it's good to have it run first. We could make the build depend on this step to prevent slowing other builds waiting in the pipeline (since we only have 5 workers) - move all pip install commands into a single line per test environment. this reduces the overhead of calling the pip command separately multiple times per environment. - removed pip upgrade command for pypy3 and py38
Adds instrumentation for python sqlite3 library.
We want to get a json of span without indent, but it's not possible with Span#to_json because the method uses hard-coded indent. We currently use a workaround of json.loads(span.to_json()) which is not efficient in the performance. Co-authored-by: alrex <aboten@lightstep.com> Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Implement the missing part of exporting the TraceProvider resource into Zipkin. Same as in js. Resources are now included into span tags. Co-authored-by: alrex <aboten@lightstep.com> Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
This adds DatadogFormatfor extracting and injecting trace contexts with Datadog-specific headers.
renaming otcollector to opencensus, as it's using opencensus under the hood. This was originally intended to be replaced by otlp, by a new package can be created for that instead. Co-authored-by: alrex <alrex.boten@gmail.com>
Right now, A resource object attached to a Span can be None. That means that there's two similar objects that refer to an empty resource: None, and the _EMPTY_RESOURCE global. We should just always default to the _EMPTY_RESOURCE object: this avoids None checks in exporters. Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Adding a unit test to the to_json method in the span. Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Incorrect import documentation in both pymongo and psycopg2.
Adding support for django 1.10+
Adding a step to test that uploading packages to pypi should work. This should prevent issues that occurred in the release of 0.7.0 from happening where a classifier was set incorrectly (3 - Beta), causing pypi to return a 400 and fail publishing packages.
More work to improve release process: - adding RELEASING.md file to describe release process - updated prepare_release.sh script to allow it to be run manually by maintainers - removed workflow to automatically publish PR, current recommendation from otel technical committee is not to use bot accounts
Fix propagation of aiohttp client traces, which were not properly injected previously. Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
This commit introduces a new boostrap command that is shipped as part of the opentelemetry-auto-instrumentation package. The command detects installed libraries and installs the relevant auto-instrumentation packages.
Adding an ASGI extension. Co-authored-by: Emil Madsen <sovende@gmail.com> Co-authored-by: alrex <alrex.boten@gmail.com> Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
Addresses #713. Previously it was possible for a user (acting against the api) to mutate a default variable.
Similar to flask, enabling exclusion of spans based on host and path. Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com> Co-authored-by: alrex <aboten@lightstep.com> Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Set the sampling rate in the Datadog exported span if span was sampled with the ProbabilitySampler. Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
…652) Adding an extension to provide users an easy mechanism to collect metrics for their system.
In PushController before exit, flush the meter by calling tick(), ensuring that all metrics are flushed. Co-authored-by: alrex <aboten@lightstep.com>
This commit ports the OpenTracing testbed[1] to check that the ot-shim is working as expected using different frameworks. Gevent doesn't support context vars yet[2], so those tests are not compatible with opentelemetry and were not ported. [1] https://github.com/opentracing/opentracing-python/tree/master/testbed [2] gevent/gevent#1407 Co-authored-by: Mauricio Vásquez <mauricio@kinvolk.io> Co-authored-by: alrex <aboten@lightstep.com>
Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Co-authored-by: Cheng-Lung Sung <clsung@gmail.com>
Canonical codes for different types of exceptions Span attributes extracted from exception Correct span closing for requests with raised errors (A span wasn't closed due to a RequestException) Co-authored-by: alrex <aboten@lightstep.com>
* Add lzchen to maintainers Closes #778. Co-authored-by: alrex <aboten@lightstep.com>
…ame opentelemetry-auto-instrumentation (#741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.