Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a environment variables handling guideline #3735

Closed
pellared opened this issue Oct 24, 2023 · 1 comment · Fixed by #3738
Closed

Add a environment variables handling guideline #3735

pellared opened this issue Oct 24, 2023 · 1 comment · Fixed by #3738
Assignees
@pellared
Labels
area:configuration Related to configuring the SDK triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal

Comments

@pellared
Copy link
Member

This text seems to be more appropriate in the sdk-environment-variables.md document, since this same thing is beyond just exporter configuration (i.e. attribute limits, processors, etc).

Originally posted by @jack-berg in #3730 (comment)

I will try to come up with some general guideline like

Environment variables MAY be handled directly by a component, in the SDK, or in a separate component.
@pellared
Copy link
Member Author

@jack-berg Can you assign me?

@pellared pellared mentioned this issue Oct 24, 2023
Merged
@jack-berg jack-berg assigned pellared and unassigned yurishkuro Oct 24, 2023
@pellared pellared mentioned this issue Oct 26, 2023
Merged
@tigrannajaryan tigrannajaryan added area:configuration Related to configuring the SDK triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal labels Nov 1, 2023
carlosalberto pushed a commit that referenced this issue Nov 7, 2023
@pellared
Add environment variable implementation guidelines (#3738)
92360f1 
Fixes
#3735

Addresses
#3730 (comment)

Supersedes
#3730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
area:configuration Related to configuring the SDK triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add environment variable implementation guidelines pellared/opentelemetry-specification
3 participants
@yurishkuro @tigrannajaryan @pellared