Add environment variable implementation guidelines #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
|
@jack-berg @bogdandrutu Can you please take a look? I want to validate it with any of you before I make the PR "ready for review". |
Kielek
reviewed
Oct 26, 2023
jack-berg
reviewed
Oct 27, 2023
|
Looks good to me, besides the comment on the "experimental" status. |
carlosalberto
approved these changes
Oct 30, 2023
jack-berg
approved these changes
Oct 30, 2023
MSNev
approved these changes
Oct 31, 2023
MrAlias
approved these changes
Oct 31, 2023
Kielek
approved these changes
Nov 2, 2023
|
Sounds like we could/should include this one in the November release? |
|
Merging this one as it's a) a follow up of the merged #3730 and b) a clarification. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3735
Addresses #3730 (comment)
Supersedes #3730
I think it is a clarification, not a breaking change. Similarly to #3730 (review)