Convert OpenMetrics Info and StateSet metrics to non-monotonic sums #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
info_stateset
branch
from
7075a91
to
1fe16c6
Compare
Aneurysm9
approved these changes
Feb 24, 2022
bogdandrutu
reviewed
Feb 25, 2022
Aneurysm9
reviewed
Feb 25, 2022
bogdandrutu
approved these changes
Feb 25, 2022
|
Since this PR now references the target info metric handing in #2381, it should wait until after that PR is merged. |
jsuereth
approved these changes
Mar 4, 2022
jmacd
reviewed
Mar 4, 2022
jmacd
reviewed
Mar 4, 2022
bogdandrutu
reviewed
Mar 4, 2022
jmacd
approved these changes
Mar 8, 2022
jmacd
changed the title
|
I think this can be merged if everyone is happy with it |
bogdandrutu
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Changes
Instead of dropping Info and StateSet metrics, we should convert them to non-monotonic sums. In the future, there may be reasons to want to preserve the original type (similar to open-telemetry/wg-prometheus#69), but for now, converting to non-monotonic sums is preferable to dropping them.
@Aneurysm9 @jmacd @brian-brazil @jsuereth