Update 1.0 branch for 1.0.3 release #955

In b6d5a8c ("Change platform ref from runtime-spec"), the conversion to runtime-spec for the "os" and "architecture" fields was removed (as the fields had also been removed in runtime-spec). Re-add the conversion as an annotation field rather than a verbatim field. Signed-off-by: Aleksa Sarai <asarai@suse.de>

Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>

This only commits the result of (make schema-fs) and is otherwise unrelated to the rest of the PR. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Signed-off-by: Francesco Mari <mari.francesco@gmail.com>

After updating gojsonschema to include xeipuuv/gojsonschema#171 , tests fail with > unable to validate: Could not read schema from HTTP, response status is 404 Not Found Before that gojsonschema change, "$ref" links were interpreted by taking the current schema source file's URI as a base, and treating "$ref" as relative to this. For example, starting with the [file://]/image-manifest-schema.json URI, as used by Validator.Validate (based on the "specs" map), the > "$ref": "content-descriptor.json" reference used to evaluate to file:///content-descriptor.json. gojsonschema.jsonReferenceLoader would then load these file:///*.json URIs via _escFS. After the gojsonschema change, "$ref" links are evaluated relative to a URI base specified by the "id" attribute inside the schema source, regardless of the "external" URI passed to the gojsonschema.JSONLoader. This is consistent with http://json-schema.org/latest/json-schema-core.html#rfc.section.8 and http://json-schema.org/latest/json-schema-core.html#rfc.section.9.2 (apart from the "id" vs. "$id" attribute name). In the same example, [file://]/image-manifest-schema.json URI contains > "id": "https://opencontainers.org/schema/image/manifest", so the same > "$ref": "content-descriptor.json" now evaluates to "https://opencontainers.org/schema/image/content-descriptor.json", which is not found by gojsonschema.jsonReferenceLoader (it uses _escFS only for file:/// URIs), resulting in the 404 quoted above. This is a minimal fix, making the schema files available to gojsonschema at the https:// URIs, while continuing to read them from _escFS. Because gojsonschema.jsonReferenceLoader can only use the provided fs for file:/// URIs, we are forced to implement our own gojsonschema.JSONLoaderFactory and gojsonschema.JSONLoader; something like this might be more generally useful and should therefore instead be provided by the gojsonschema library. This particular JSONLoader{Factory,} implementation, though, is image-spec specific because it locally works around various inconsistencies in the image-spec JSON schemas, and thus is not suitable for gojsonschema as is. Namely, the specs/*.json schema files use URIs with two URI path prefixes, https://opencontainers.org/schema/{,image/} in the top-level "id" attributes, and the nested "id" attributes along with "$ref" references use _several more_ URI path prefixes, e.g. > "id": "https://opencontainers.org/schema/image/manifest/annotations", > "$ref": "defs-descriptor.json#/definitions/annotations" in image-manifest-schema.json specifies the https://opencontainers.org/schema/image/manifest/defs-descriptor.json URI. In fact, defs-descriptor.json references use all of the following URIs: > https://opencontainers.org/schema/defs-descriptor.json > https://opencontainers.org/schema/image/defs-descriptor.json > https://opencontainers.org/schema/image/descriptor/defs-descriptor.json > https://opencontainers.org/schema/image/index/defs-descriptor.json > https://opencontainers.org/schema/image/manifest/defs-descriptor.json So, this commit introduces a loader which preserves the original _escFS layout by recognizing and stripping all of these prefixes, and using the same /*.json paths for _escFS lookups as before; this is clearly unsuitable for gojsonschema inclusion. Finally, the reason this commit uses such a fairly hacky loader is that merely changing the _escFS structure is still not sufficient to get consistent schema: the schema/*.json paths in this repository, and the "$ref" values, do not match the "id" values inside the schemas at all. E.g. image-manifest-schema.json refers to https://opencontainers.org/schema/image/manifest/content-descriptor.json , while content-descriptor.json identifies itself as https://opencontainers.org/schema/descriptor , matching neither the path prefix nor the file name. Overall, it is completely unclear to me which of the URIs is the canonical URI of the "content descriptor" schema, and the owner of the URI namespace needs to decide on the canonical schema URIs. Only afterwards can the code be cleanly modified to match the specification; until then, this commit at least keeps the tests passing, and the validator usable by external callers who want to use the public image-spec/schema.ValidateMediaType*.Validate() API. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

The "id" values in JSON schema files must be unique, per RFC draft 8.3.1: > A schema MAY (and likely will) have multiple URIs, but there is no > way for a URI to identify more than one schema. and recent gojsonschema fails when handling such inputs (fairly nontransparently, it silently fails to resolve $ref references to absolute URIs and reports something like > Reference defs.json#/definitions/mapStringString must be canonical .) In particular, the https://opencontainers.org/schema/image/descriptor/annotations id value had three definitions. To resolve this: - Leave the definition in image-index-schema.json; although using the /descriptor subnamespace for the "manifests" array is a bit surprising, the /image/ part clearly belongs to image-index-schema.json - Rename the id definition in content-descriptor.json, to use the generic "blob descriptor" namespace. - Remove the definition in defs-descriptor.json; that seems to be an "utility" schema file describing common structures, but it's better for users to reference schema fragments by purpose than by common structure (so that we can let the structure diverge in the future if necessary). Finally, changing the content-descriptor.json "id" value changes the resolved absolute value of the reference to defs-descriptor.json, so add another namespace to be handled by fsLoaderFactory. Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Move "prefix" to out of the code backtick. Signed-off-by: Yusuke Nakamura <yusuke1994525@gmail.com>

Signed-off-by: Jimmy Zelinskie <jimmy.zelinskie+git@gmail.com>

Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>

Signed-off-by: xiekeyang <keyang.xie@gmail.com>

Closes opencontainers#766 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Make error string non-capitalized, to fix linting problem Signed-off-by: Odin Ugedal <odin@ugedal.com>

Signed-off-by: Odin Ugedal <odin@ugedal.com>

Closes: opencontainers#787 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Point to one canonical location for meeting details, frequency, minutes, agenda, etc. Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

Signed-off-by: Jonathan Boulle <jonathanboulle@gmail.com>

Add go constants for the zstd MIME types to make them usable by consumers of the go package. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

…gzip Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>

I have not been active in the project for quite some time so I am stepping down. Thank you for all of the work over the years to standardize container formats everyone! Signed-off-by: Brandon Philips <brandon@ifup.org>

The offset to line/col translation is easy to implement. Not worthy to bring a third-party dependency. PS. I think this code is never used, but removing it is too aggressive since it exposes public api. Signed-off-by: Shengjing Zhu <zhsj@debian.org>

Signed-off-by: Mohammed Daoudi <m.iduoad@gmail.com>

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Switch approved by Jason Bouzane via email to OCI TOB mailing list. Signed-off-by: Phil Estes <estesp@gmail.com>

Signed-off-by: Jason Hall <jasonhall@redhat.com>

Signed-off-by: Jonathan Boulle <jonathanboulle@gmail.com>

Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>

Signed-off-by: Jason Hall <jasonhall@redhat.com>

Previous maintainers should be thanked for their work. Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com> Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

This should be equivalent to the .travis-ci workflow, but run in GitHub actions. I am using the exact commit of the v1 release, as that is considered safer practice than the tag/release itself. Signed-off-by: vsoch <vsoch@users.noreply.github.com>

like opencontainers/distribution-spec@199cf0e#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52 Fixes: opencontainers#773 Closes: opencontainers#774 Signed-off-by: Yang Bo <bo@hyper.sh> Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Missing "to" in Volumes description. Signed-off-by: Jon Johnson <jonjohnson@google.com>

There doesn't seem to be an introduction in this file (and the link goes to itself?) so I think we probably want to remove it (or link to an introduction elsewhere?) Signed-off-by: vsoch <vsoch@users.noreply.github.com>

Signed-off-by: Jason Hall <jasonhall@redhat.com>

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Signed-off-by: Jason Hall <jasonhall@redhat.com>

On github darkmode is really hard to follow the specification because png images expects a light background. Signed-off-by: Luciano Queiroz <luciiano.queiroz@gmail.com>

The OCI scope table no-longer exists. Drop the reference to it in the README. Fixes opencontainers#812 Signed-off-by: Aidan Delaney <aidan.delaney@gmail.com>

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

…eferences failure, not success Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>

This commit adds the CPU variant to the image config type. It also refactors the image index specification to isolate the platform variant specifications, allowing a reference from the config spec. The go specs are updated to include the new field in the v1.Image struct, and tests are updated to include the new field. Signed-off-by: Chris Price <chris.price@docker.com>

Signed-off-by: Ashok Pon Kumar <ashokponkumar@gmail.com>

This should contain an embedded representation of the referenced content, which is useful for avoiding extra hops to access small pieces of content. Signed-off-by: Jon Johnson <jonjohnson@google.com>

Signed-off-by: Jon Johnson <jonjohnson@google.com>

Also add a counterexample. Signed-off-by: Jon Johnson <jonjohnson@google.com>

Also fix typo. Signed-off-by: Jon Johnson <jonjohnson@google.com>

Signed-off-by: Jason Hall <jasonhall@redhat.com>

This makes sure that an index can be generated from an image spec. `OSVersion` in particular is fairly important for Windows since Windows can only run containers for the OS version it was built for, and currently the only way to reliably get this is from the index. Signed-off-by: Brian Goff <cpuguy83@gmail.com>

While registries might want to verify the data field, we shouldn't rely on it, as many registries are unaware of this field. On the other hand, clients SHOULD verify the content before consuming it. Signed-off-by: Jon Johnson <jonjohnson@google.com>

OCI media types are slightly different from Docker ones, e.g., Docker manifests must have `.mediaType` field while OCI may not have. Also, OCI descriptors may have `.annotations` while Docker may not. Also updates to compare the spec with Docker Image Spec v1.2, not v1.0. OCI Image Spec v1 is more akin to Docker Image Spec v1.2 rather than v1.0, which lacked content addressability. See also https://github.com/moby/moby/blob/v20.10.1/image/spec/README.md for differencces between Docker Image Spec v1.2 and v1.0. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

Fixes opencontainers#872 Signed-off-by: Jérôme Petazzoni <jerome.petazzoni@gmail.com>

Fixed a minor typo / spelling mistake. Signed-off-by: wyckster <wyckster@hotmail.com>

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Signed-off-by: Josh Dolitsky <josh@dolit.ski>

Closes opencontainers#810 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Signed-off-by: Stephen Day <stephen.day@getcruise.com>

The OCI scope table no-longer exists. Fixes opencontainers#812 Signed-off-by: sanshirookazaki <sanshirookazaki@gmail.com>

Signed-off-by: Brandon Mitchell <git@bmitch.net>

having seen opencontainers#895, it's worth ensuring these other languages are listed implementations Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Signed-off-by: Brandon Mitchell <git@bmitch.net>

Signed-off-by: Michael Brown <brownxmi@amazon.com>

Signed-off-by: Josh Dolitsky <josh@dolit.ski>

Signed-off-by: Brandon Mitchell <git@bmitch.net>

Signed-off-by: Josh Dolitsky <josh@dolit.ski>

Signed-off-by: Brandon Mitchell <git@bmitch.net>

This is a PR template to propose adding new maintainers Fixes opencontainers#912 Signed-off-by: nisha <nisha@ctlfsh.tech>

Signed-off-by: Brandon Mitchell <git@bmitch.net>

Signed-off-by: Sajay Antony <sajaya@microsoft.com>

io/ioutil is deprecated since Go 1.16 Signed-off-by: Austin Vazquez <macedonv@amazon.com>

Signed-off-by: Brandon Mitchell <git@bmitch.net>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update 1.0 branch for 1.0.3 release #955

Update 1.0 branch for 1.0.3 release #955

Commits on Sep 25, 2022