OPENEUROPA-1501: Implement configuration UI for Authentication. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidtek
reviewed
Jan 8, 2019
| $form['protocol'] = [ | ||
| '#type' => 'textfield', | ||
| '#title' => $this->t('Application authentication protocol'), | ||
| '#default_value' => $this->config(static::CONFIGNAME)->get('protocol'), |
There was a problem hiding this comment.
"#description" could be useful.
This remark is relevant to other fields too.
There was a problem hiding this comment.
There are no description provided in the configurations either. I would not add anything based on my own assumption.
voidtek
reviewed
Jan 8, 2019
voidtek
reviewed
Jan 8, 2019
nagyad
force-pushed
the
OPENEUROPA-1501
branch
from
092430f
to
b361293
Compare
upchuk
requested changes
Jan 10, 2019
nagyad
force-pushed
the
OPENEUROPA-1501
branch
from
b361293
to
cdffafb
Compare
nagyad
force-pushed
the
OPENEUROPA-1501
branch
from
cdffafb
to
930e50f
Compare
upchuk
previously approved these changes
Jan 10, 2019
imanoleguskiza
suggested changes
Jan 10, 2019
|
|
||
| @DrupalLogin @BackupAuthConfigs | ||
| Scenario: Configure Authentication settings | ||
| Given I am on "admin/config/system/oe_authentication" |
There was a problem hiding this comment.
Same scenario as openeuropa/oe_webtools#24 (comment)
imanoleguskiza
approved these changes
Jan 11, 2019
imanoleguskiza
approved these changes
Jan 11, 2019
upchuk
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-1501
Provide the Authentication module with a UI so that users with appropriate permissions can edit and change module configuration.