-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPENEUROPA-1500: Create configuration UI for Webtools Analytics module #24
Conversation
a795713
to
ca8df1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SiteID must be an integer. Probably worth adding either validation or at least a comment on the form.
Changes to the form are only picked up after the cache is cleared. Again, worth adding a cache clear as part of the form submission.
The test should be extended to check that the form fields are being used.
I have implemented the requested changes. The cache is going to be worked on with a followup ticket since the current solution requires some improvements. |
I will also implement a custom permission for this. |
c28ecd1
to
e1a9e9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 now
modules/oe_webtools_analytics/src/Form/WebtoolsAnalyticsSettingsForm.php
Outdated
Show resolved
Hide resolved
modules/oe_webtools_analytics/src/Form/WebtoolsAnalyticsSettingsForm.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 all good now!
modules/oe_webtools_analytics/oe_webtools_analytics.permissions.yml
Outdated
Show resolved
Hide resolved
e1a2306
to
a5716ca
Compare
…e the custom validation hook.
3230356
to
e615e06
Compare
tests/features/analytics.feature
Outdated
@BackupAnalyticsConfigs | ||
Scenario: Create Webtools Analytics settings | ||
Given I am logged in as a user with the "administer webtools analytics" permission | ||
And I am on "admin/config/system/oe_webtools_analytics" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the transformation context to turn this path into a business readable string, such as:
And I am on "the Webtools Analytics configuration page"
And then in the behat.yml.dist
:
- OpenEuropa\Behat\TransformationContext:
pages:
Webtools Analytics configuration: "/admin/config/system/oe_webtools_analytics"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work for me.
/** | ||
* Name of the config being edited. | ||
*/ | ||
const CONFIGNAME = 'oe_webtools_analytics.settings'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename this into WebtoolsAnalyticsSettingsForm::CONFIG_NAME
.
b129823
to
623fe57
Compare
623fe57
to
04f742d
Compare
OPENEUROPA-1500
Provide the Webtools Analytics with a UI so that users with appropriate permissions can edit and change webtools configuration.