OPENEUROPA-1500: Create configuration UI for Webtools Analytics module #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagyad
changed the title
nagyad
force-pushed
the
OPENEUROPA-1500
branch
from
a795713
to
ca8df1f
Compare
upchuk
previously approved these changes
Jan 4, 2019
richardcanoe
suggested changes
Jan 4, 2019
There was a problem hiding this comment.
SiteID must be an integer. Probably worth adding either validation or at least a comment on the form.
Changes to the form are only picked up after the cache is cleared. Again, worth adding a cache clear as part of the form submission.
The test should be extended to check that the form fields are being used.
|
I have implemented the requested changes. The cache is going to be worked on with a followup ticket since the current solution requires some improvements. |
|
I will also implement a custom permission for this. |
richardcanoe
previously approved these changes
Jan 8, 2019
drupol
force-pushed
the
OPENEUROPA-1500
branch
from
c28ecd1
to
e1a9e9a
Compare
richardcanoe
previously approved these changes
Jan 8, 2019
drupol
suggested changes
Jan 8, 2019
modules/oe_webtools_analytics/src/Form/WebtoolsAnalyticsSettingsForm.php
Outdated
Show resolved
Hide resolved
modules/oe_webtools_analytics/src/Form/WebtoolsAnalyticsSettingsForm.php
Show resolved
Hide resolved
drupol
reviewed
Jan 8, 2019
modules/oe_webtools_analytics/oe_webtools_analytics.permissions.yml
Outdated
Show resolved
Hide resolved
drupol
force-pushed
the
OPENEUROPA-1500
branch
from
e1a2306
to
a5716ca
Compare
upchuk
requested changes
Jan 9, 2019
…e the custom validation hook.
nagyad
force-pushed
the
OPENEUROPA-1500
branch
from
3230356
to
e615e06
Compare
upchuk
previously approved these changes
Jan 10, 2019
upchuk
previously approved these changes
Jan 10, 2019
ademarco
requested changes
Jan 10, 2019
tests/features/analytics.feature
Outdated
| @BackupAnalyticsConfigs | ||
| Scenario: Create Webtools Analytics settings | ||
| Given I am logged in as a user with the "administer webtools analytics" permission | ||
| And I am on "admin/config/system/oe_webtools_analytics" |
There was a problem hiding this comment.
We should use the transformation context to turn this path into a business readable string, such as:
And I am on "the Webtools Analytics configuration page"
And then in the behat.yml.dist:
- OpenEuropa\Behat\TransformationContext:
pages:
Webtools Analytics configuration: "/admin/config/system/oe_webtools_analytics"
There was a problem hiding this comment.
This does not work for me.
| /** | ||
| * Name of the config being edited. | ||
| */ | ||
| const CONFIGNAME = 'oe_webtools_analytics.settings'; |
There was a problem hiding this comment.
Let's rename this into WebtoolsAnalyticsSettingsForm::CONFIG_NAME.
nagyad
force-pushed
the
OPENEUROPA-1500
branch
from
b129823
to
623fe57
Compare
upchuk
previously approved these changes
Jan 11, 2019
nagyad
force-pushed
the
OPENEUROPA-1500
branch
from
623fe57
to
04f742d
Compare
upchuk
approved these changes
Jan 11, 2019
ademarco
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-1500
Provide the Webtools Analytics with a UI so that users with appropriate permissions can edit and change webtools configuration.