Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Follow-up] Fix extraction script #4895

Merged
merged 2 commits into from
Sep 13, 2023
Merged

[Follow-up] Fix extraction script #4895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b52b8b
fix-script
curq Sep 1, 2023
585d7eb
fix additional script errors
curq Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ugins/discover/public/application/components/doc_views/context/utils/use_query_actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export function useQueryActions(anchorId: string, indexPattern: IndexPattern) {
}));
}
toastNotifications.addDanger({
title: i18n.translate('discover.context.unableToLoadDocumentDescription', {
title: i18n.translate('discover.context.unableToLoadSurroundingDocumentDescription', {
defaultMessage: 'Unable to fetch surrounding documents',
}),
text: 'fail',
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/discover/public/application/components/doc_views/single_doc_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function SingleDocApp() {
...getRootBreadcrumbs(),
{
text: i18n.translate('discover.single.breadcrumb', {
defaultMessage: `${index}#${docId}`,
defaultMessage: '{index}#{docId}',
values: {
index,
docId,
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/discover/public/application/view_components/utils/index_pattern_helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ export function resolveIndexPattern(

if (stateVal && !stateValFound) {
const warningTitle = i18n.translate('discover.valueIsNotConfiguredIndexPatternIDWarningTitle', {
defaultMessage: '{stateVal} is not a configured index pattern ID',
defaultMessage: '{id} is not a configured index pattern ID',
values: {
stateVal: `"${stateVal}"`,
id: `"${stateVal}"`,
},
});

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/vis_type_vega/public/expressions/line_vega_spec_fn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const createLineVegaSpecFn = (
name: 'line_vega_spec',
type: 'string',
inputTypes: ['opensearch_dashboards_datatable'],
help: i18n.translate('visTypeVega.function.help', {
help: i18n.translate('visTypeVega.function.helpSpec', {
defaultMessage: 'Construct line vega spec',
}),
args: {
Expand Down
3 changes: 2 additions & 1 deletion src/plugins/visualizations/public/embeddable/visualize_embeddable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,8 @@ export class VisualizeEmbeddable
const { toasts } = getNotifications();
toasts.addError(err, {
title: i18n.translate('visualizations.renderVisTitle', {
defaultMessage: `Error loading data on the ${this.vis.title} chart`,
defaultMessage: 'Error loading data on the {visTitle} chart',
values: { visTitle: this.vis.title },
}),
toastMessage: ' ',
id: this.id,
Expand Down
Loading