[Follow-up] Fix extraction script #4895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
curq
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
curq
added
backport 2.x
Skip-Changelog
Codecov Report
@@ Coverage Diff @@
## main #4895 +/- ##
==========================================
- Coverage 66.39% 66.39% -0.01%
==========================================
Files 3397 3397
Lines 64804 64804
Branches 10360 10360
==========================================
- Hits 43028 43026 -2
- Misses 19217 19218 +1
- Partials 2559 2560 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AMoo-Miki
approved these changes
Sep 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
* fix-script * fix additional script errors --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> (cherry picked from commit 4e1c370) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this pull request
Sep 13, 2023
* fix-script * fix additional script errors --------- (cherry picked from commit 4e1c370) Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up fix to #4794, after the initial bug was solved in this pr. There were 2 additional errors that prevented script from running after I tried to running script later.
I tried running script again after some time and there were 3 more new errors
It looks like they were introduced in recent PRs related to discover.
Issues Resolved
#4794
Screenshot
Testing the changes
We can test it by running the script from #4794
./scripts/use_node scripts/i18n_extract.js --output-dir plugins/dashboards-i18n/translations/It will create en.json file in output directory without any errors. If no such directory we can output result to root directory to check./scripts/use_node scripts/i18n_extract.js --output-dir plugins/dashboards-i18n/translations/Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr