Condence context menus #7057

AMoo-Miki · 2024-06-19T00:19:04Z

Hold for @kgcreative and Viraj's signoff.

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: Miki <miki@amazon.com>

github-actions · 2024-06-19T00:19:44Z

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

github-actions · 2024-06-19T00:20:57Z

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

codecov · 2024-06-19T00:33:35Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.44%. Comparing base (a4aa682) to head (3525031).
Report is 37 commits behind head on main.

Files	Patch %	Lines
...gins/share/public/components/url_panel_content.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7057      +/-   ##
==========================================
- Coverage   67.44%   67.44%   -0.01%     
==========================================
  Files        3444     3445       +1     
  Lines       67865    67886      +21     
  Branches    11027    11037      +10     
==========================================
+ Hits        45772    45783      +11     
- Misses      19429    19434       +5     
- Partials     2664     2669       +5

Flag	Coverage Δ
Linux_1	`33.07% <0.00%> (ø)`
Linux_2	`55.11% <ø> (ø)`
Linux_3	`45.25% <ø> (+0.01%)`	⬆️
Linux_4	`?`
Windows_1	`33.10% <0.00%> (ø)`
Windows_2	`55.06% <ø> (ø)`
Windows_3	`45.25% <ø> (+0.01%)`	⬆️
Windows_4	`34.86% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kavilla · 2024-06-20T00:39:03Z

is the proposal within OSD or are these examples for potentially having the default values in OUI be smaller? so it hits the entire app?

virajsanghvi

We probably need to follow up with 1) strategy on which changes will need to be behind a flag, 2) whether popover defaults should be made at OUI level and 3) how to address small context menu titles being a smaller size than popover titles even though body text size is the same, but changes lgtm and these could be addressed after.

virajsanghvi · 2024-06-21T23:31:48Z

src/plugins/data/public/ui/filter_bar/filter_options.tsx

@@ -179,13 +179,13 @@ class FilterOptionsUI extends Component<Props, State> {
        panelPaddingSize="none"
        repositionOnScroll
      >
-        <EuiPopoverTitle>
+        <EuiPopoverTitle paddingSize="s">


Do you think its better to do these locally rather than set a default through OUI?

Due to the potential blast radius, I think we should localize these changes. ~~I am also concerned about different fonts and font-sizes across themes and their impact on all of these.~~ did the math and the diff is too little to be concerned about.

AMoo-Miki · 2024-06-28T20:57:47Z

is the proposal within OSD or are these examples for potentially having the default values in OUI be smaller? so it hits the entire app?

There is a big collection of changes. Some are done globally within OUI (via a new theme) and some are done surgically. There will most likely be some that will go behind a config flag too.

Hailong-am · 2024-07-17T03:23:58Z

@AMoo-Miki seem test snapshot update was missed, that cause CI to fail https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/9966986613/job/27539949592?pr=7254

* Condense share context menu Signed-off-by: Miki <miki@amazon.com> * Condense console editor actions context menu Signed-off-by: Miki <miki@amazon.com> * Condense filter bar context menus Signed-off-by: Miki <miki@amazon.com> * Condense discover table options context menu Signed-off-by: Miki <miki@amazon.com> * Condense new panel creation context menus Signed-off-by: Miki <miki@amazon.com> * Condense index pattern creation button's menu Signed-off-by: Miki <miki@amazon.com> * Condense index pattern creation wizard's pagination context menu Signed-off-by: Miki <miki@amazon.com> * Condense inspect flyout's view selection context menu Signed-off-by: Miki <miki@amazon.com> * Condense inspect flyout's download options context menu Signed-off-by: Miki <miki@amazon.com> * Condense inspect flyout's request selection context menu Signed-off-by: Miki <miki@amazon.com> * Condense panel-adding flyout's filter menus Signed-off-by: Miki <miki@amazon.com> * Condense group adding context menu in visualization editor Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit f1be0d6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Condense share context menu * Condense console editor actions context menu * Condense filter bar context menus * Condense discover table options context menu * Condense new panel creation context menus * Condense index pattern creation button's menu * Condense index pattern creation wizard's pagination context menu * Condense inspect flyout's view selection context menu * Condense inspect flyout's download options context menu * Condense inspect flyout's request selection context menu * Condense panel-adding flyout's filter menus * Condense group adding context menu in visualization editor --------- (cherry picked from commit f1be0d6) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

AMoo-Miki added 12 commits June 14, 2024 12:02

Condense share context menu

ccdea53

Signed-off-by: Miki <miki@amazon.com>

Condense console editor actions context menu

7dc79d0

Signed-off-by: Miki <miki@amazon.com>

Condense filter bar context menus

eb02ed8

Signed-off-by: Miki <miki@amazon.com>

Condense discover table options context menu

0b65b0c

Signed-off-by: Miki <miki@amazon.com>

Condense new panel creation context menus

d985bc7

Signed-off-by: Miki <miki@amazon.com>

Condense index pattern creation button's menu

47f8774

Signed-off-by: Miki <miki@amazon.com>

Condense index pattern creation wizard's pagination context menu

cee3bd4

Signed-off-by: Miki <miki@amazon.com>

Condense inspect flyout's view selection context menu

6987609

Signed-off-by: Miki <miki@amazon.com>

Condense inspect flyout's download options context menu

3372e8a

Signed-off-by: Miki <miki@amazon.com>

Condense inspect flyout's request selection context menu

f0d9df0

Signed-off-by: Miki <miki@amazon.com>

Condense panel-adding flyout's filter menus

82a0f2a

Signed-off-by: Miki <miki@amazon.com>

Condense group adding context menu in visualization editor

3525031

Signed-off-by: Miki <miki@amazon.com>

AMoo-Miki requested review from ananzh, kavilla, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT, xinruiba, zhyuanqi and mengweieric as code owners June 19, 2024 00:19

github-actions bot added the distinguished-contributor label Jun 19, 2024

github-actions bot added the failed changeset label Jun 19, 2024

virajsanghvi approved these changes Jun 21, 2024

View reviewed changes

virajsanghvi added the look & feel Look and Feel Improvements label Jul 10, 2024

zhongnansu approved these changes Jul 16, 2024

View reviewed changes

zhongnansu merged commit f1be0d6 into opensearch-project:main Jul 16, 2024
68 of 72 checks passed

This was referenced Jul 17, 2024

[navigation-next] Add new category #7276

Merged

[navigation-next] Add new left navigation #7230

Merged

AMoo-Miki added backport 2.x v2.16.0 labels Jul 17, 2024

opensearch-trigger-bot bot mentioned this pull request Jul 17, 2024

[Backport 2.x] Condence context menus #7286

Merged

zhongnansu mentioned this pull request Jul 25, 2024

[Look&Feel] Use small context menu across the board #7486

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Condence context menus #7057

Condence context menus #7057

AMoo-Miki commented Jun 19, 2024 •

edited

Loading

github-actions bot commented Jun 19, 2024

github-actions bot commented Jun 19, 2024

codecov bot commented Jun 19, 2024 •

edited

Loading

kavilla commented Jun 20, 2024

virajsanghvi left a comment

virajsanghvi Jun 21, 2024

AMoo-Miki Jun 28, 2024 •

edited

Loading

AMoo-Miki commented Jun 28, 2024

Hailong-am commented Jul 17, 2024

Condence context menus #7057

Condence context menus #7057

Conversation

AMoo-Miki commented Jun 19, 2024 • edited Loading

Check List

github-actions bot commented Jun 19, 2024

❌ Invalid Changelog Heading

github-actions bot commented Jun 19, 2024

❌ Invalid Changelog Heading

codecov bot commented Jun 19, 2024 • edited Loading

Codecov Report

kavilla commented Jun 20, 2024

virajsanghvi left a comment

Choose a reason for hiding this comment

virajsanghvi Jun 21, 2024

Choose a reason for hiding this comment

AMoo-Miki Jun 28, 2024 • edited Loading

Choose a reason for hiding this comment

AMoo-Miki commented Jun 28, 2024

Hailong-am commented Jul 17, 2024

AMoo-Miki commented Jun 19, 2024 •

edited

Loading

codecov bot commented Jun 19, 2024 •

edited

Loading

AMoo-Miki Jun 28, 2024 •

edited

Loading