Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condence context menus #7057

Merged
merged 12 commits into from
Jul 16, 2024
Merged

Condence context menus #7057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ccdea53
Condense share context menu
AMoo-Miki Jun 11, 2024
7dc79d0
Condense console editor actions context menu
AMoo-Miki Jun 11, 2024
eb02ed8
Condense filter bar context menus
AMoo-Miki Jun 11, 2024
0b65b0c
Condense discover table options context menu
AMoo-Miki Jun 11, 2024
d985bc7
Condense new panel creation context menus
AMoo-Miki Jun 11, 2024
47f8774
Condense index pattern creation button's menu
AMoo-Miki Jun 11, 2024
cee3bd4
Condense index pattern creation wizard's pagination context menu
AMoo-Miki Jun 11, 2024
6987609
Condense inspect flyout's view selection context menu
AMoo-Miki Jun 11, 2024
3372e8a
Condense inspect flyout's download options context menu
AMoo-Miki Jun 11, 2024
f0d9df0
Condense inspect flyout's request selection context menu
AMoo-Miki Jun 12, 2024
82a0f2a
Condense panel-adding flyout's filter menus
AMoo-Miki Jun 12, 2024
3525031
Condense group adding context menu in visualization editor
AMoo-Miki Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/console/public/application/components/console_menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export class ConsoleMenu extends Component<Props, State> {
panelPaddingSize="none"
anchorPosition="downLeft"
>
<EuiContextMenuPanel items={items} />
<EuiContextMenuPanel items={items} size="s" />
</EuiPopover>
</span>
);
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/data/public/ui/filter_bar/filter_item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ export function FilterItem(props: Props) {
anchorPosition="downLeft"
panelPaddingSize="none"
>
<EuiContextMenu initialPanelId={0} panels={getPanels()} />
<EuiContextMenu initialPanelId={0} panels={getPanels()} size="s" />
</EuiPopover>
);
}
4 changes: 2 additions & 2 deletions src/plugins/data/public/ui/filter_bar/filter_options.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,13 +179,13 @@ class FilterOptionsUI extends Component<Props, State> {
panelPaddingSize="none"
repositionOnScroll
>
<EuiPopoverTitle>
<EuiPopoverTitle paddingSize="s">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think its better to do these locally rather than set a default through OUI?

Copy link
Collaborator Author

@AMoo-Miki AMoo-Miki Jun 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the potential blast radius, I think we should localize these changes. I am also concerned about different fonts and font-sizes across themes and their impact on all of these. did the math and the diff is too little to be concerned about.

<FormattedMessage
id="data.filter.searchBar.changeAllFiltersTitle"
defaultMessage="Change all filters"
/>
</EuiPopoverTitle>
<EuiContextMenu initialPanelId={0} panels={[panelTree]} />
<EuiContextMenu initialPanelId={0} panels={[panelTree]} size="s" />
</EuiPopover>
);
}
Expand Down
1 change: 1 addition & 0 deletions src/plugins/discover/public/application/view_components/canvas/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ export default function DiscoverCanvas({ setHeaderActionMenu, history }: ViewPro
>
<EuiContextMenu
initialPanelId={0}
size="s"
panels={[
{
id: 0,
Expand Down
2 changes: 1 addition & 1 deletion .../public/lib/panel/panel_header/panel_actions/add_panel/saved_object_finder_create_new.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export function SavedObjectFinderCreateNew({ menuItems }: Props) {
panelPaddingSize="none"
anchorPosition="downRight"
>
<EuiContextMenuPanel items={menuItems} />
<EuiContextMenuPanel items={menuItems} size="s" />
</EuiPopover>
);
}
3 changes: 2 additions & 1 deletion src/plugins/index_pattern_management/public/components/create_button/create_button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,15 @@ export class CreateButton extends Component<Props, State> {
anchorPosition="downLeft"
>
<EuiContextMenuPanel
size="s"
items={options.map((option) => {
return (
<EuiContextMenuItem
key={option.text}
onClick={option.onClick}
data-test-subj={option.testSubj}
>
<EuiDescriptionList style={{ whiteSpace: 'nowrap' }}>
<EuiDescriptionList style={{ whiteSpace: 'nowrap' }} compressed={true}>
<EuiDescriptionListTitle>
{option.text}
{option.isBeta ? <Fragment> {this.renderBetaBadge()}</Fragment> : null}
Expand Down
2 changes: 1 addition & 1 deletion ...dex_pattern_wizard/components/step_index_pattern/components/indices_list/indices_list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ export class IndicesList extends React.Component<IndicesListProps, IndicesListSt
closePopover={this.closePerPageControl}
panelPaddingSize="none"
>
<EuiContextMenuPanel items={items} />
<EuiContextMenuPanel items={items} size="s" />
</EuiPopover>
</EuiFlexItem>
{paginationControls}
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/inspector/public/ui/inspector_view_chooser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export class InspectorViewChooser extends Component<Props, State> {
anchorPosition="downRight"
repositionOnScroll
>
<EuiContextMenuPanel items={views.map(this.renderView)} />
<EuiContextMenuPanel items={views.map(this.renderView)} size="s" />
</EuiPopover>
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/inspector/public/views/data/components/download_options.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class DataDownloadOptions extends Component<DataDownloadOptionsProps, DataDownlo
panelPaddingSize="none"
repositionOnScroll
>
<EuiContextMenuPanel className="eui-textNoWrap" items={items} />
<EuiContextMenuPanel className="eui-textNoWrap" items={items} size="s" />
</EuiPopover>
);
}
Expand Down
1 change: 1 addition & 0 deletions src/plugins/inspector/public/views/requests/components/request_selector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ export class RequestSelector extends Component<RequestSelectorProps, RequestSele
<EuiContextMenuPanel
items={this.props.requests.map(this.renderRequestDropdownItem)}
data-test-subj="inspectorRequestChooserMenuPanel"
size="s"
/>
</EuiPopover>
);
Expand Down
2 changes: 2 additions & 0 deletions src/plugins/saved_objects/public/finder/saved_object_finder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ class SavedObjectFinderUi extends React.Component<
<EuiContextMenuPanel
watchedItemProps={['icon', 'disabled']}
items={this.getSortOptions()}
size="s"
/>
</EuiPopover>
{this.props.showFilter && (
Expand Down Expand Up @@ -456,6 +457,7 @@ class SavedObjectFinderUi extends React.Component<
>
<EuiContextMenuPanel
watchedItemProps={['icon', 'disabled']}
size="s"
items={this.props.savedObjectMetaData.map((metaData) => (
<EuiContextMenuItem
key={metaData.type}
Expand Down
1 change: 1 addition & 0 deletions src/plugins/share/public/components/share_context_menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export class ShareContextMenu extends Component<Props> {
initialPanelId={initialPanelId}
panels={panels}
data-test-subj="shareContextMenu"
size="s"
/>
</I18nProvider>
);
Expand Down
25 changes: 14 additions & 11 deletions src/plugins/share/public/components/url_panel_content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import {
EuiFlexItem,
EuiForm,
EuiFormRow,
EuiText,
EuiIconTip,
EuiLoadingSpinner,
EuiRadioGroup,
Expand Down Expand Up @@ -134,17 +135,19 @@ export class UrlPanelContent extends Component<Props, State> {
data-test-subj="copyShareUrlButton"
size="s"
>
{this.props.isEmbedded ? (
<FormattedMessage
id="share.urlPanel.copyIframeCodeButtonLabel"
defaultMessage="Copy iFrame code"
/>
) : (
<FormattedMessage
id="share.urlPanel.copyLinkButtonLabel"
defaultMessage="Copy link"
/>
)}
<EuiText size="s">
{this.props.isEmbedded ? (
<FormattedMessage
id="share.urlPanel.copyIframeCodeButtonLabel"
defaultMessage="Copy iFrame code"
/>
) : (
<FormattedMessage
id="share.urlPanel.copyLinkButtonLabel"
defaultMessage="Copy link"
/>
)}
</EuiText>
</EuiButton>
)}
</EuiCopy>
Expand Down
3 changes: 2 additions & 1 deletion src/plugins/vis_default_editor/public/components/agg_add.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ function DefaultEditorAggAdd({
repositionOnScroll={true}
closePopover={() => setIsPopoverOpen(false)}
>
<EuiPopoverTitle>
<EuiPopoverTitle paddingSize="s">
{(groupName !== AggGroupNames.Buckets || !stats.count) && (
<FormattedMessage
id="visDefaultEditor.aggAdd.addGroupButtonLabel"
Expand All @@ -116,6 +116,7 @@ function DefaultEditorAggAdd({
)}
</EuiPopoverTitle>
<EuiContextMenuPanel
size="s"
items={schemas.map((schema) => (
<EuiContextMenuItem
key={`${schema.name}_${schema.title}`}
Expand Down
Loading