-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x][navigation-next] Add new left navigation (#7230) #7300
Merged
SuZhou-Joe
merged 1 commit into
opensearch-project:feature/navigation-next-2.x
from
SuZhou-Joe:backport-left-navigation-change
Jul 18, 2024
Merged
[Backport 2.x][navigation-next] Add new left navigation (#7230) #7300
SuZhou-Joe
merged 1 commit into
opensearch-project:feature/navigation-next-2.x
from
SuZhou-Joe:backport-left-navigation-change
Jul 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(opensearch-project#7093) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: enable parent nav link id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify left navigation Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify style Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: enable left bottom Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * temp: merge Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: save Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: merge Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * temp change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * temp change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: overview page can not be load Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: new application Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update category based on latest design Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: do not emphasize see all link Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR opensearch-project#7230 created/updated * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
July 18, 2024 07:40
github-actions
bot
added
the
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
label
Jul 18, 2024
SuZhou-Joe
merged commit Jul 18, 2024
b28aa98
into
opensearch-project:feature/navigation-next-2.x
3 of 4 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(#7093) * feat: enable parent nav link id * feat: modify left navigation * feat: modify style * feat: enable left bottom * temp: merge * feat: save * feat: merge * temp change * temp change * fix: overview page can not be load * feat: remove useless change * feat: add unit test * feat: update snapshot * fix: unit test error * fix: new application * feat: add unit test * feat: update category based on latest design * feat: update * feat: update snapshot * feat: do not emphasize see all link * Changeset file for PR #7230 created/updated * feat: update * feat: update --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b28aa98) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 18, 2024
* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(#7093) * feat: enable parent nav link id * feat: modify left navigation * feat: modify style * feat: enable left bottom * temp: merge * feat: save * feat: merge * temp change * temp change * fix: overview page can not be load * feat: remove useless change * feat: add unit test * feat: update snapshot * fix: unit test error * fix: new application * feat: add unit test * feat: update category based on latest design * feat: update * feat: update snapshot * feat: do not emphasize see all link * Changeset file for PR #7230 created/updated * feat: update * feat: update --------- (cherry picked from commit b28aa98) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #7230
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration