Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x][navigation-next] Add new left navigation (#7230) #7301

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[Backport 2.x][navigation-next] Add new left navigation (#7230) #7301

merged 1 commit into from
Jul 18, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jul 18, 2024 •
edited by SuZhou-Joe
Loading

Backport b28aa98 from #7300.
Backport 38ae65b from #7230.

Changelog

  • skip

@github-actions @opensearch-changeset-bot
[navigation-next] Add new left navigation (#7230) (#7300)
3bde1dc 
* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(#7093)

* feat: enable parent nav link id

* feat: modify left navigation

* feat: modify style

* feat: enable left bottom

* temp: merge

* feat: save

* feat: merge

* temp change

* temp change

* fix: overview page can not be load

* feat: remove useless change

* feat: add unit test

* feat: update snapshot

* fix: unit test error

* fix: new application

* feat: add unit test

* feat: update category based on latest design

* feat: update

* feat: update snapshot

* feat: do not emphasize see all link

* Changeset file for PR #7230 created/updated

* feat: update

* feat: update

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit b28aa98)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Jul 18, 2024
@SuZhou-Joe SuZhou-Joe changed the title [Backport 2.x] [Backport 2.x][navigation-next] Add new left navigation (#7230) [Backport 2.x][navigation-next] Add new left navigation (#7230) Jul 18, 2024
@github-actions github-actions bot added failed changeset Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry failed changeset labels Jul 18, 2024
@opensearch-project opensearch-project deleted a comment from github-actions bot Jul 18, 2024
@opensearch-project opensearch-project deleted a comment from github-actions bot Jul 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.35849% with 36 lines in your changes missing coverage. Please review.

Project coverage is 67.93%. Comparing base (49677e9) to head (3bde1dc).

Files Patch % Lines
...chrome/ui/header/collapsible_nav_group_enabled.tsx 87.01% 2 Missing and 8 partials ⚠️
src/core/public/chrome/ui/header/header.tsx 14.28% 6 Missing ⚠️
...rc/plugins/data_source_management/public/plugin.ts 54.54% 4 Missing and 1 partial ⚠️
.../plugins/index_pattern_management/public/plugin.ts 54.54% 4 Missing and 1 partial ⚠️
.../plugins/saved_objects_management/public/plugin.ts 50.00% 4 Missing and 1 partial ⚠️
src/plugins/advanced_settings/public/plugin.ts 42.85% 3 Missing and 1 partial ⚠️
src/plugins/home/public/plugin.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #7301      +/-   ##
==========================================
+ Coverage   67.72%   67.93%   +0.20%     
==========================================
  Files        3452     3455       +3     
  Lines       68309    68467     +158     
  Branches    11113    11146      +33     
==========================================
+ Hits        46265    46514     +249     
+ Misses      19364    19250     -114     
- Partials     2680     2703      +23
Flag Coverage Δ
Linux_1 33.24% <2.30%> (-0.09%) ⬇️
Linux_2 55.58% <85.04%> (+0.16%) ⬆️
Linux_3 42.88% <13.29%> (-2.18%) ⬇️
Windows_1 33.26% <2.30%> (-0.09%) ⬇️
Windows_2 55.53% <85.04%> (+0.16%) ⬆️
Windows_3 42.89% <13.29%> (-2.17%) ⬇️
Windows_4 34.86% <9.80%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit ac22fd2 into 2.x Jul 18, 2024
67 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruanyl @SuZhou-Joe