[Workspace] Hide first home breadcrumbs within workspace #7992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 4, 2024
|
@AMoo-Miki @zhongnansu can you help to review this change? |
Hailong-am
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7992 +/- ##
=======================================
Coverage 60.52% 60.52%
=======================================
Files 3728 3728
Lines 88297 88300 +3
Branches 13662 13663 +1
=======================================
+ Hits 53439 53444 +5
+ Misses 31603 31602 -1
+ Partials 3255 3254 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 5, 2024
Hailong-am
force-pushed
the
hide_home_breadcrumbs_for_workspace
branch
from
d48a366
to
d2d7262
Compare
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
SuZhou-Joe
force-pushed
the
hide_home_breadcrumbs_for_workspace
branch
from
d2d7262
to
b83d54f
Compare
Signed-off-by: Hailong Cui <ihailong@amazon.com>
ruanyl
reviewed
Sep 5, 2024
| @@ -73,6 +75,10 @@ export function HeaderBreadcrumbs({ | |||
| crumbs = breadcrumbEnricher(crumbs); | |||
| } | |||
|
|
|||
| if (dropHomeFromBreadcrumb && crumbs.length && Object.hasOwn(crumbs[0], 'home')) { | |||
There was a problem hiding this comment.
Do we need to check if home is true?
There was a problem hiding this comment.
we could add this condition as well. There only have one place to set this additional property, i think it's ok only check existence.
There was a problem hiding this comment.
Can we have the assumption that when home is set, it must be true?
There was a problem hiding this comment.
Yes, i think so. home is not a defined property on ChromeBreadcrumb, ideally nobody else will set this property
SuZhou-Joe
approved these changes
Sep 5, 2024
ruanyl
approved these changes
Sep 5, 2024
|
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
* hide first home breadcrumbs within workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR #7992 created/updated * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 63d0d32) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 5, 2024
…ce (#8015) * [Workspace] Hide first home breadcrumbs within workspace (#7992) * hide first home breadcrumbs within workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR #7992 created/updated * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 63d0d32) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix 2.x issue (#8021) Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
…ce (#8015) * [Workspace] Hide first home breadcrumbs within workspace (#7992) * hide first home breadcrumbs within workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR #7992 created/updated * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 63d0d32) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix 2.x issue (#8021) Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit ee2656b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 6, 2024
…ce (#8015) (#8050) * [Workspace] Hide first home breadcrumbs within workspace (#7992) * hide first home breadcrumbs within workspace * Changeset file for PR #7992 created/updated * don't relay on text to drop home * don't relay on text to drop home --------- (cherry picked from commit 63d0d32) * fix 2.x issue (#8021) --------- (cherry picked from commit ee2656b) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hide the home breadcrumbs when we are in a workspace, but keep it in recent popover
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration