Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Workspace] Hide first home breadcrumbs within workspace #8015

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 63d0d32 from #7992.

* hide first home breadcrumbs within workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Changeset file for PR #7992 created/updated

* don't relay on text to drop home

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* don't relay on text to drop home

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 63d0d32)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.62%. Comparing base (d88e3b0) to head (bb6a3bc).
Report is 10 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8015      +/-   ##
==========================================
+ Coverage   60.60%   60.62%   +0.01%     
==========================================
  Files        3727     3728       +1     
  Lines       88292    88319      +27     
  Branches    13652    13659       +7     
==========================================
+ Hits        53512    53540      +28     
+ Misses      31529    31527       -2     
- Partials     3251     3252       +1     
Flag Coverage Δ
Linux_1 28.74% <20.00%> (?)
Linux_2 56.36% <100.00%> (+<0.01%) ⬆️
Linux_3 37.43% <0.00%> (-0.01%) ⬇️
Linux_4 29.74% <0.00%> (+0.01%) ⬆️
Windows_1 28.75% <20.00%> (+<0.01%) ⬆️
Windows_2 56.32% <100.00%> (+<0.01%) ⬆️
Windows_3 37.43% <0.00%> (-0.01%) ⬇️
Windows_4 29.74% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am mentioned this pull request Sep 5, 2024
7 tasks
Signed-off-by: Hailong Cui <ihailong@amazon.com>
@SuZhou-Joe SuZhou-Joe merged commit ee2656b into 2.x Sep 5, 2024
63 of 65 checks passed
@opensearch-trigger-bot
Copy link
Contributor Author

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-8015-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ee2656b5992c7cd655616ae347b92c76a0c6be16
# Push it to GitHub
git push --set-upstream origin backport/backport-8015-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-8015-to-2.17.

@opensearch-trigger-bot
Copy link
Contributor Author

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-8015-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ee2656b5992c7cd655616ae347b92c76a0c6be16
# Push it to GitHub
git push --set-upstream origin backport/backport-8015-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-8015-to-2.17.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
…ce (#8015)

* [Workspace] Hide first home breadcrumbs within workspace (#7992)

* hide first home breadcrumbs within workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Changeset file for PR #7992 created/updated

* don't relay on text to drop home

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* don't relay on text to drop home

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 63d0d32)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix 2.x issue (#8021)

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit ee2656b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 6, 2024
…ce (#8015) (#8050)

* [Workspace] Hide first home breadcrumbs within workspace (#7992)

* hide first home breadcrumbs within workspace



* Changeset file for PR #7992 created/updated

* don't relay on text to drop home



* don't relay on text to drop home



---------



(cherry picked from commit 63d0d32)


* fix 2.x issue (#8021)



---------






(cherry picked from commit ee2656b)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants