Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster state stats #10670

Merged
merged 12 commits into from
Oct 24, 2023
Merged

Conversation

amkhar
Copy link
Contributor

@amkhar amkhar commented Oct 17, 2023

Description

Add cluster state stats from cluster manager's prospective. Include remote state upload stats within same structure of nodes/stats discovery section.

New object being added to nodes/stats

"cluster_state_stats" : {
          "overall" : {
            "update_count" : 9,
            "total_time_in_millis" : 807,
            "failed_count" : 0
          },
          "remote_upload" : {
            "success_count" : 9,
            "failed_count" : 0,
            "total_time_in_millis" : 116,
            "cleanup_attempt_failed_count" : 0
          }
        }

New output of _nodes/stats/discovery

{
  "_nodes" : {
    "total" : 1,
    "successful" : 1,
    "failed" : 0
  },
  "cluster_name" : "runTask",
  "nodes" : {
    "3gqqkXTzSvCfhiI0sBhPBg" : {
      "timestamp" : 1697612114787,
      "name" : "runTask-0",
      "transport_address" : "127.0.0.1:9300",
      "host" : "127.0.0.1",
      "ip" : "127.0.0.1:9300",
      "roles" : [
        "cluster_manager",
        "data",
        "ingest",
        "remote_cluster_client"
      ],
      "attributes" : {
        "testattr" : "test",
        "remote_store.state.repository" : "my-fs-repository",
        "remote_store.repository.my-fs-repository.settings.location" : "repo",
        "shard_indexing_pressure_enabled" : "true",
        "remote_store.segment.repository" : "my-fs-repository",
        "remote_store.translog.repository" : "my-fs-repository",
        "remote_store.repository.my-fs-repository.type" : "fs"
      },
      "discovery" : {
        "cluster_state_queue" : {
          "total" : 0,
          "pending" : 0,
          "committed" : 0
        },
        "published_cluster_states" : {
          "full_states" : 2,
          "incompatible_diffs" : 0,
          "compatible_diffs" : 7
        },
        "cluster_state_stats" : {
          "overall" : {
            "update_count" : 9,
            "total_time_in_millis" : 807,
            "failed_count" : 0
          },
          "remote_upload" : {
            "success_count" : 9,
            "failed_count" : 0,
            "total_time_in_millis" : 116,
            "cleanup_attempt_failed_count" : 0
          }
        }
      }
    }
  }
}

Related Issues

Resolves - 10669

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Aman Khare <amkhar@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Compatibility status:

Checks if related components are compatible with change 2b50d4e

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@amkhar
Copy link
Contributor Author

amkhar commented Oct 18, 2023

Gradle Check (Jenkins) Run Completed with:

Flaky test testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness - #3603

@amkhar
Copy link
Contributor Author

amkhar commented Oct 23, 2023

Gradle Check (Jenkins) Run Completed with:

testSendCorruptBytesToReplica - Flaky : #10709

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@amkhar
Copy link
Contributor Author

amkhar commented Oct 24, 2023

Gradle Check (Jenkins) Run Completed with:

Flaky test CardinalityWithRequestBreakerIT : #10154

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@shwetathareja
Copy link
Member

shwetathareja commented Oct 24, 2023

@shwetathareja shwetathareja merged commit 54e74a8 into opensearch-project:main Oct 24, 2023
10 of 14 checks passed
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Oct 24, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 24, 2023
* Add cluster state update stats along with remote upload stats around success/ failure, latency metric

Signed-off-by: Aman Khare <amkhar@amazon.com>
(cherry picked from commit 54e74a8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja pushed a commit that referenced this pull request Oct 25, 2023
* Add cluster state stats (#10670)
* Add cluster state update stats along with remote upload stats around success/ failure, latency metric
* Change backward compatibility version to 2.12 for 2.x merge

Signed-off-by: Aman Khare <amkhar@amazon.com>
(cherry picked from commit 54e74a8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* Add cluster state update stats along with remote upload stats around success/ failure, latency metric

Signed-off-by: Aman Khare <amkhar@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants