Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix flaky test testFlushThrowsFlushFailedExceptionOnCorruption. #10678

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8b04521 from #10671.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Compatibility status:

Checks if related components are compatible with change 0e31606

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member

mch2 commented Oct 18, 2023

Gradle Check (Jenkins) Run Completed with:

#10314

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

This test is flaky in two ways, one it may hit a case where a merge occurs and the hardcoded segment does not exist to delete.
Two with certain mock filesystems a corruption exception won't be thrown here, only a NoSuchFile - This doesn't change our
handling in the engine, but the test should conditionally handle if the store is marked corrupted on close.

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit 8b04521)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mch2 mch2 force-pushed the backport/backport-10671-to-2.x branch from b4858ff to 0e31606 Compare October 20, 2023 17:04
@mch2
Copy link
Member

mch2 commented Oct 20, 2023

pushed a rebase here to fix build of bwcLinuxtar

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #10678 (0e31606) into 2.x (8896f58) will decrease coverage by 0.10%.
Report is 1 commits behind head on 2.x.
The diff coverage is 81.48%.

@@             Coverage Diff              @@
##                2.x   #10678      +/-   ##
============================================
- Coverage     70.94%   70.84%   -0.10%     
+ Complexity    58705    58662      -43     
============================================
  Files          4843     4843              
  Lines        277261   277278      +17     
  Branches      40673    40675       +2     
============================================
- Hits         196690   196450     -240     
- Misses        63858    64166     +308     
+ Partials      16713    16662      -51     
Files Coverage Δ
.../indices/replication/common/ReplicationTarget.java 72.50% <100.00%> (-5.14%) ⬇️
...nsearch/index/store/RemoteStoreFileDownloader.java 92.15% <84.00%> (-0.87%) ⬇️
...ices/replication/RemoteStoreReplicationSource.java 85.24% <75.00%> (-5.83%) ⬇️

... and 466 files with indirect coverage changes

@kotwanikunal kotwanikunal merged commit 7c038b3 into 2.x Oct 20, 2023
16 checks passed
@github-actions github-actions bot deleted the backport/backport-10671-to-2.x branch October 20, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants