Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix flaky test testFlushThrowsFlushFailedExceptionOnCorruption. #10678

Merged
merged 1 commit into from
Oct 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -614,11 +614,18 @@ public void testFlushThrowsFlushFailedExceptionOnCorruption() throws Exception {
indexOperations(nrtEngine, operations);
// wipe the nrt directory initially so we can sync with primary.
cleanAndCopySegmentsFromPrimary(nrtEngine);
nrtEngineStore.directory().deleteFile("_0.si");
final Optional<String> toDelete = Set.of(nrtEngineStore.directory().listAll()).stream().filter(f -> f.endsWith(".si")).findAny();
assertTrue(toDelete.isPresent());
nrtEngineStore.directory().deleteFile(toDelete.get());
assertThrows(FlushFailedEngineException.class, nrtEngine::flush);
assertTrue(nrtEngineStore.isMarkedCorrupted());
// store will throw when eventually closed, not handled here.
assertThrows(RuntimeException.class, nrtEngineStore::close);
nrtEngine.close();
if (nrtEngineStore.isMarkedCorrupted()) {
assertThrows(RuntimeException.class, nrtEngineStore::close);
} else {
// With certain mock directories a NoSuchFileException is thrown which is not treated as a
// corruption Exception. In these cases we don't expect any issue on store close.
nrtEngineStore.close();
}
}

private void copySegments(Collection<String> latestPrimaryFiles, Engine nrtEngine) throws IOException {
Expand Down
Loading