Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in API annotation check message #11836

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

lukas-vlcek
Copy link
Contributor

@lukas-vlcek lukas-vlcek commented Jan 10, 2024

Description

Spotted a typo in API annotation check message

> Task :server:compileJava
Note: Processing Log4j annotations
Note: Annotations processed
Note: Processing OpenSearch Api annotations
Note: The element org.opensearch.common.inject.Module is part of the public APIs but is not maked as @PublicApi, @ExperimentalApi or @DeprecatedApi (referenced by org.opensearch.plugins.Plugin)
                                                                                       (here ⬆︎)

Fix typo in API annotation check message.
(Fixing some internal comments as well.)

Related Issues

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for c395a6b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jan 10, 2024

Compatibility status:

Checks if related components are compatible with change d055341

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

- Fixing some internal comments as well

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Copy link
Contributor

❌ Gradle check result for 96c6221: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for d055341: SUCCESS

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a42150) 71.41% compared to head (d055341) 71.41%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11836   +/-   ##
=========================================
  Coverage     71.41%   71.41%           
- Complexity    59292    59320   +28     
=========================================
  Files          4919     4919           
  Lines        278912   278912           
  Branches      40543    40543           
=========================================
+ Hits         199191   199196    +5     
+ Misses        63171    63111   -60     
- Partials      16550    16605   +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator

reta commented Jan 10, 2024

Thanks @lukas-vlcek !

@reta reta merged commit feeb595 into opensearch-project:main Jan 10, 2024
33 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Jan 10, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11836-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 feeb595be5c998efca4d11d65ea6a3d00cea17dd
# Push it to GitHub
git push --set-upstream origin backport/backport-11836-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-11836-to-2.x.

@reta
Copy link
Collaborator

reta commented Jan 10, 2024

@lukas-vlcek could you please backport to 2.x manually? thank you!

lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this pull request Jan 11, 2024
- Fixing some internal comments as well

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
(cherry picked from commit feeb595)
@lukas-vlcek
Copy link
Contributor Author

@reta FYI, backport PR: #11860

@lukas-vlcek lukas-vlcek deleted the fix_message_typo branch January 11, 2024 14:36
reta pushed a commit that referenced this pull request Jan 11, 2024
- Fixing some internal comments as well

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
(cherry picked from commit feeb595)
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
- Fixing some internal comments as well

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
- Fixing some internal comments as well

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants