Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Fix typo in API annotation check message (#11836) #11860

Merged

Conversation

lukas-vlcek
Copy link
Contributor

Description

  • Fixing some internal comments as well

Signed-off-by: Lukáš Vlček lukas.vlcek@aiven.io
(cherry picked from commit feeb595)

Related Issues

Resolves #11836

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

- Fixing some internal comments as well

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
(cherry picked from commit feeb595)
@github-actions github-actions bot added backport 2.x Backport to 2.x branch backport-failed labels Jan 11, 2024
@reta reta changed the title Fix typo in API annotation check message (#11836) [Backport] [2.x] Fix typo in API annotation check message (#11836) Jan 11, 2024
@reta reta removed the backport 2.x Backport to 2.x branch label Jan 11, 2024
@github-actions github-actions bot added the backport 2.x Backport to 2.x branch label Jan 11, 2024
@reta reta removed backport 2.x Backport to 2.x branch backport-failed labels Jan 11, 2024
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 2e7eccf

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❕ Gradle check result for 2e7eccf: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString_FailOpenEnabled
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (a41646e) 71.16% compared to head (2e7eccf) 71.08%.
Report is 6 commits behind head on 2.x.

Files Patch % Lines
...ch/common/xcontent/JsonToStringXContentParser.java 81.25% 1 Missing and 2 partials ⚠️
.../java/org/opensearch/index/codec/CodecService.java 66.66% 2 Missing ⚠️
...org/opensearch/index/fielddata/IndexFieldData.java 33.33% 1 Missing and 1 partial ⚠️
...eldcomparator/HalfFloatValuesComparatorSource.java 0.00% 1 Missing ⚠️
...comparator/UnsignedLongValuesComparatorSource.java 0.00% 1 Missing ⚠️
...opensearch/index/mapper/CompletionFieldMapper.java 0.00% 1 Missing ⚠️
.../index/search/comparators/HalfFloatComparator.java 0.00% 1 Missing ⚠️
...dex/search/comparators/UnsignedLongComparator.java 0.00% 1 Missing ⚠️
...opensearch/search/sort/GeoDistanceSortBuilder.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11860      +/-   ##
============================================
- Coverage     71.16%   71.08%   -0.09%     
+ Complexity    59378    59320      -58     
============================================
  Files          4889     4889              
  Lines        279821   279805      -16     
  Branches      41034    41032       -2     
============================================
- Hits         199141   198897     -244     
- Misses        63778    64067     +289     
+ Partials      16902    16841      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit a8e3e64 into opensearch-project:2.x Jan 11, 2024
84 checks passed
@lukas-vlcek lukas-vlcek deleted the backport/backport-11836-to-2.x branch January 11, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants