Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release latch listeners in case of no-op RoutingTableService #15614

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Release latch listeners in case of no-op RoutingTableService #15614

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc815d4
Release latch listeners in case of no-op RoutingTableService
shiv0408 Sep 3, 2024
b6fdbcc
Merge branch 'main' into noop-rrt
shiv0408 Sep 5, 2024
81682d4
Merge branch 'main' into noop-rrt
shiv0408 Sep 5, 2024
937e34f
Add UT
shiv0408 Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...er/src/main/java/org/opensearch/cluster/routing/remote/NoopRemoteRoutingTableService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
IndexRoutingTable indexRouting,
LatchedActionListener<ClusterMetadataManifest.UploadedMetadata> latchedActionListener
) {
// noop
latchedActionListener.onResponse(null);

Check warning on line 46 in server/src/main/java/org/opensearch/cluster/routing/remote/NoopRemoteRoutingTableService.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/cluster/routing/remote/NoopRemoteRoutingTableService.java#L46 

Added line #L46 was not covered by tests
}

@Override
Expand All @@ -54,7 +54,7 @@
StringKeyDiffProvider<IndexRoutingTable> routingTableDiff,
LatchedActionListener<ClusterMetadataManifest.UploadedMetadata> latchedActionListener
) {
// noop
latchedActionListener.onResponse(null);

Check warning on line 57 in server/src/main/java/org/opensearch/cluster/routing/remote/NoopRemoteRoutingTableService.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/cluster/routing/remote/NoopRemoteRoutingTableService.java#L57 

Added line #L57 was not covered by tests
}

@Override
Expand All @@ -73,7 +73,7 @@
String uploadedFilename,
LatchedActionListener<IndexRoutingTable> latchedActionListener
) {
// noop
latchedActionListener.onResponse(null);

Check warning on line 76 in server/src/main/java/org/opensearch/cluster/routing/remote/NoopRemoteRoutingTableService.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/cluster/routing/remote/NoopRemoteRoutingTableService.java#L76 

Added line #L76 was not covered by tests
}

@Override
Expand All @@ -82,7 +82,7 @@
String uploadedFilename,
LatchedActionListener<Diff<RoutingTable>> latchedActionListener
) {
// noop
latchedActionListener.onResponse(null);

Check warning on line 85 in server/src/main/java/org/opensearch/cluster/routing/remote/NoopRemoteRoutingTableService.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/cluster/routing/remote/NoopRemoteRoutingTableService.java#L85 

Added line #L85 was not covered by tests
}

@Override
Expand Down
Loading