Release latch listeners in case of no-op RoutingTableService #15614
Conversation
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for cc815d4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for cc815d4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b6fdbcc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15614 +/- ##
============================================
- Coverage 71.95% 71.87% -0.09%
+ Complexity 64192 64159 -33
============================================
Files 5270 5271 +1
Lines 300052 300170 +118
Branches 43368 43380 +12
============================================
- Hits 215917 215740 -177
- Misses 66442 66686 +244
- Partials 17693 17744 +51 ☔ View full report in Codecov by Sentry. |
|
|
||
| public void testGetAsyncIndexRoutingWriteAction() throws InterruptedException { | ||
| CountDownLatch latch = new CountDownLatch(1); | ||
| TestCapturingListener<ClusterMetadataManifest.UploadedMetadata> capturingListener = new TestCapturingListener<>(); |
There was a problem hiding this comment.
Instead of this you can pass a listener with onResponse/onFailure overridden to set an Atomic result. Then all you can do is check whether that result was set or not after await
There was a problem hiding this comment.
Actually, I added this Listener in #14394. Basically does the same thing by overriding the onResponse/onFailure, but it isn't atomic that shouldn't be issue for our usecase I believe.
Description
We are currently blocking the latched listeners in case of NoopRemoteRoutingTableService read and write actions. In case of publication is being disabled or enabled by rolling restart. Some nodes will be running on Noop service but will timeout downloading the cluster state.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.