-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release latch listeners in case of no-op RoutingTableService #15614
Open
shiv0408
wants to merge
4
commits into
opensearch-project:main
Choose a base branch
from
shiv0408:noop-rrt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
...c/test/java/org/opensearch/cluster/routing/remote/NoopRemoteRoutingTableServiceTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
/* | ||
* SPDX-License-Identifier: Apache-2.0 | ||
* | ||
* The OpenSearch Contributors require contributions made to | ||
* this file be licensed under the Apache-2.0 license or a | ||
* compatible open source license. | ||
*/ | ||
|
||
package org.opensearch.cluster.routing.remote; | ||
|
||
import org.opensearch.action.LatchedActionListener; | ||
import org.opensearch.cluster.Diff; | ||
import org.opensearch.cluster.routing.IndexRoutingTable; | ||
import org.opensearch.cluster.routing.RoutingTable; | ||
import org.opensearch.common.util.TestCapturingListener; | ||
import org.opensearch.gateway.remote.ClusterMetadataManifest; | ||
import org.opensearch.test.OpenSearchTestCase; | ||
import org.junit.Before; | ||
|
||
import java.util.concurrent.CountDownLatch; | ||
import java.util.concurrent.TimeUnit; | ||
|
||
public class NoopRemoteRoutingTableServiceTests extends OpenSearchTestCase { | ||
private NoopRemoteRoutingTableService service; | ||
|
||
@Before | ||
public void setup() { | ||
service = new NoopRemoteRoutingTableService(); | ||
} | ||
|
||
public void testGetAsyncIndexRoutingWriteAction() throws InterruptedException { | ||
CountDownLatch latch = new CountDownLatch(1); | ||
TestCapturingListener<ClusterMetadataManifest.UploadedMetadata> capturingListener = new TestCapturingListener<>(); | ||
LatchedActionListener<ClusterMetadataManifest.UploadedMetadata> listener = new LatchedActionListener<>(capturingListener, latch); | ||
service.getAsyncIndexRoutingWriteAction("clusterUUID", 1, 1, null, listener); | ||
latch.await(100, TimeUnit.MILLISECONDS); | ||
assertNull(capturingListener.getResult()); | ||
} | ||
|
||
public void testGetAsyncIndexRoutingReadAction() throws InterruptedException { | ||
CountDownLatch latch = new CountDownLatch(1); | ||
TestCapturingListener<IndexRoutingTable> capturingListener = new TestCapturingListener<>(); | ||
LatchedActionListener<IndexRoutingTable> listener = new LatchedActionListener<>(capturingListener, latch); | ||
service.getAsyncIndexRoutingReadAction("clusterUUID", "filename", listener); | ||
latch.await(100, TimeUnit.MILLISECONDS); | ||
assertNull(capturingListener.getResult()); | ||
} | ||
|
||
public void testGetAsyncIndexRoutingDiffWriteAction() throws InterruptedException { | ||
CountDownLatch latch = new CountDownLatch(1); | ||
TestCapturingListener<ClusterMetadataManifest.UploadedMetadata> capturingListener = new TestCapturingListener<>(); | ||
LatchedActionListener<ClusterMetadataManifest.UploadedMetadata> listener = new LatchedActionListener<>(capturingListener, latch); | ||
service.getAsyncIndexRoutingDiffWriteAction("clusterUUID", 1, 1, null, listener); | ||
latch.await(100, TimeUnit.MILLISECONDS); | ||
assertNull(capturingListener.getResult()); | ||
} | ||
|
||
public void testGetAsyncIndexRoutingDiffReadAction() throws InterruptedException { | ||
CountDownLatch latch = new CountDownLatch(1); | ||
TestCapturingListener<Diff<RoutingTable>> capturingListener = new TestCapturingListener<>(); | ||
LatchedActionListener<Diff<RoutingTable>> listener = new LatchedActionListener<>(capturingListener, latch); | ||
service.getAsyncIndexRoutingTableDiffReadAction("clusterUUID", "filename", listener); | ||
latch.await(100, TimeUnit.MILLISECONDS); | ||
assertNull(capturingListener.getResult()); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this you can pass a listener with
onResponse
/onFailure
overridden to set an Atomic result. Then all you can do is check whether that result was set or not after awaitThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I added this Listener in #14394. Basically does the same thing by overriding the
onResponse
/onFailure
, but it isn't atomic that shouldn't be issue for our usecase I believe.