Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Fixing flaky test - RemoteIndexPrimaryRelocationIT #9807

Conversation

psychbot
Copy link
Member

@psychbot psychbot commented Sep 6, 2023

Description

Fixing Flaky Test - https://github.com/opensearch-project/OpenSearch/actions/runs/6094377255/job/16535787653?pr=9664

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Compatibility status:

Checks if related components are compatible with change 845ee41

Incompatible components

Incompatible components: [https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Compatibility status:

Checks if related components are compatible with change 70e6eab

Incompatible components

Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #9807 (70e6eab) into main (19a13f0) will increase coverage by 0.06%.
Report is 9 commits behind head on main.
The diff coverage is 78.31%.

@@             Coverage Diff              @@
##               main    #9807      +/-   ##
============================================
+ Coverage     71.14%   71.20%   +0.06%     
- Complexity    57973    58089     +116     
============================================
  Files          4825     4829       +4     
  Lines        273348   273740     +392     
  Branches      39841    39887      +46     
============================================
+ Hits         194473   194930     +457     
+ Misses        62523    62447      -76     
- Partials      16352    16363      +11     
Files Changed Coverage Δ
...on/admin/indices/shrink/TransportResizeAction.java 49.24% <0.00%> (-18.47%) ⬇️
...pensearch/common/settings/IndexScopedSettings.java 100.00% <ø> (ø)
...java/org/opensearch/discovery/DiscoveryModule.java 90.27% <ø> (ø)
...in/java/org/opensearch/indices/IndicesService.java 70.37% <ø> (+0.01%) ⬆️
.../org/opensearch/repositories/FilterRepository.java 5.88% <0.00%> (-0.12%) ⬇️
...n/java/org/opensearch/repositories/Repository.java 28.57% <ø> (ø)
...ofile/aggregation/AggregationProfileBreakdown.java 0.00% <ø> (ø)
...g/opensearch/repositories/RepositoriesService.java 72.40% <42.85%> (-1.45%) ⬇️
...rch/search/profile/ContextualProfileBreakdown.java 75.00% <50.00%> (-25.00%) ⬇️
...ch/repositories/blobstore/BlobStoreRepository.java 60.78% <52.63%> (+0.23%) ⬆️
... and 24 more

... and 463 files with indirect coverage changes

@sachinpkale sachinpkale merged commit 1b41fa0 into opensearch-project:main Sep 6, 2023
14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2023
)

* [Remote Store] Fixing flaky test - RemoteIndexPrimaryRelocationIT

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

* Adding numDataNodes to 0 for remot store tests

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

---------

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>
(cherry picked from commit 1b41fa0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@psychbot psychbot deleted the flaky-testPrimaryRelocationWhileIndexing-fix branch September 6, 2023 14:07
sachinpkale pushed a commit that referenced this pull request Sep 6, 2023
) (#9819)

* [Remote Store] Fixing flaky test - RemoteIndexPrimaryRelocationIT



* Adding numDataNodes to 0 for remot store tests



---------


(cherry picked from commit 1b41fa0)

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…ensearch-project#9807)

* [Remote Store] Fixing flaky test - RemoteIndexPrimaryRelocationIT

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

* Adding numDataNodes to 0 for remot store tests

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

---------

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…ensearch-project#9807)

* [Remote Store] Fixing flaky test - RemoteIndexPrimaryRelocationIT

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

* Adding numDataNodes to 0 for remot store tests

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

---------

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ensearch-project#9807)

* [Remote Store] Fixing flaky test - RemoteIndexPrimaryRelocationIT

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

* Adding numDataNodes to 0 for remot store tests

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>

---------

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants