Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] bump plugin version to 2.0.0.0-rc1 #213

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Apr 11, 2022

Description

To be supported within the distribution for OSD 2.0.0-rc1 from the build repo, plugins need to ensure their plugin version is the expected version until opensearch-project/OpenSearch-Dashboards#1398 is addressed. If OSD plugins version does not match the qualifier of the build then the build will fail.

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kavilla kavilla requested a review from a team April 11, 2022 23:15
@kavilla kavilla added the v2.0.0 label Apr 11, 2022
@kavilla kavilla requested a review from AWSHurneyt April 11, 2022 23:22
@kavilla
Copy link
Member Author

kavilla commented Apr 12, 2022

@AWSHurneyt are the current failures due to this plugin not being compatible with OSD 2.0 post node upgrade?

@AWSHurneyt
Copy link
Collaborator

@AWSHurneyt are the current failures due to this plugin not being compatible with OSD 2.0 post node upgrade?

I was actually just taking a look into that; let me get back to you.

@AWSHurneyt
Copy link
Collaborator

@AWSHurneyt are the current failures due to this plugin not being compatible with OSD 2.0 post node upgrade?

I was actually just taking a look into that; let me get back to you.

Apologies for the late response. These tests are failing on main currently as well; they seem to be flaky due to some destination migration logic that was merged to the backend recently. We'll discuss as a team how to best handle the flakiness of these cypress tests tomorrow.

@kavilla
Copy link
Member Author

kavilla commented Apr 13, 2022

@AWSHurneyt would you be opposed to merging this in? Otherwise the other solution would be removing it from the 2.0 manifest for OpenSearch Dashboards. Otherwise the build will fail.

@AWSHurneyt
Copy link
Collaborator

@AWSHurneyt would you be opposed to merging this in? Otherwise the other solution would be removing it from the 2.0 manifest for OpenSearch Dashboards. Otherwise the build will fail.

This PR comments out the flaky portion of those tests #214

It's been merged now, so I believe the checks in this PR should start passing once your bump_to_rc1 branch is rebased.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla merged commit 00ce5ff into opensearch-project:main Apr 14, 2022
@kavilla kavilla deleted the avillk/bump_to_rc1 branch April 14, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants