Temporarily disabled destination use in some cypress tests to resolve flakiness. #214
Conversation
… flakiness. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
=======================================
Coverage 56.79% 56.79%
=======================================
Files 198 198
Lines 4756 4756
Branches 651 651
=======================================
Hits 2701 2701
Misses 2053 2053
Partials 2 2 Continue to review full report at Codecov.
|
|
Ran the cypress tests 3 times using github, and a few times locally to help ensure they are no longer flaky. |
|
Will any change in the migration backend logic which could lead to regression will be suppressed until these tests are fixed. Do we need to add an issue for the quick follow up |
Agreed. Created this issue to track this opensearch-project/alerting#403 |
Copy-paste with changes that were committed from the alerting dashboards plugin. Source PR: opensearch-project/alerting-dashboards-plugin#214 Issue resolved: N/A Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy-paste with changes that were committed from the alerting dashboards plugin. Source PR: opensearch-project/alerting-dashboards-plugin#214 Issue resolved: N/A Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: AWSHurneyt hurneyt@amazon.com
Description
Automatic destination migration to notification channels was causing destinations to be deleted while cypress tests were executing. For now, we're commenting out the portions of those tests that use destinations. The tests will be refactored in the future to make use of notification channels once the notifications frontend is implemented.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.