Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented support for action execution configurations for doc level monitors #237

Closed

Conversation

AWSHurneyt
Copy link
Collaborator

Description

  1. Refactored actions component for doc level monitors to support configuration action execution options.
  2. Implemented an example trigger condition for doc level monitors that are defined using the extraction query editor.
  3. Implemented additional form-reset logic when changing monitor types.
  4. Moved getDefaultScript to a separate helper class, and refactored the unit tests, to accommodate other monitor types.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…are defined using the extraction query editor. Implemented additional form-reset logic when changing monitor types. Moved getDefaultScript to a separate helper class, and refactored the unit tests, to accommodate other monitor types.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…uration action execution options.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #237 (e3909c3) into main (a082826) will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   52.15%   52.39%   +0.23%     
==========================================
  Files         209      209              
  Lines        5407     5413       +6     
  Branches      741      741              
==========================================
+ Hits         2820     2836      +16     
+ Misses       2585     2575      -10     
  Partials        2        2              
Impacted Files Coverage Δ
...rigger/containers/CreateTrigger/utils/constants.js 100.00% <0.00%> (ø)
.../containers/ConfigureTriggers/ConfigureTriggers.js 0.00% <0.00%> (ø)
.../containers/CreateTrigger/utils/formikToTrigger.js 32.02% <0.00%> (ø)
...tricsMonitor/utils/clusterMetricsMonitorHelpers.js 100.00% <0.00%> (ø)
...reateMonitor/components/MonitorType/MonitorType.js 34.78% <0.00%> (+6.21%) ⬆️
...CreateTrigger/components/Action/actions/Message.js 66.03% <0.00%> (+6.94%) ⬆️
...-plugin/public/pages/CreateTrigger/utils/helper.js 66.66% <0.00%> (+38.09%) ⬆️
.../FormControls/FormikFieldRadio/FormikFieldRadio.js 80.00% <0.00%> (+40.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a082826...e3909c3. Read the comment docs.

@AWSHurneyt AWSHurneyt marked this pull request as ready for review May 11, 2022 17:00
@AWSHurneyt AWSHurneyt requested a review from a team May 11, 2022 17:00
@AWSHurneyt
Copy link
Collaborator Author

Closing in favor of #240

@AWSHurneyt AWSHurneyt closed this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants