Fixed issues found during bug bash, and implemented tests #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
…r clarity. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
… have default values. Refactored validation logic for doc level queries. Implemented unit tests for various doc level monitor functions. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…removed redundant code. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…are defined using the extraction query editor. Implemented additional form-reset logic when changing monitor types. Moved getDefaultScript to a separate helper class, and refactored the unit tests, to accommodate other monitor types. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…uration action execution options. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…ts table to allow multiple flyouts to be open at once. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…vel monitors defined with the visual editor. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…queries/tags when using the visual editor. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…that automatically. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
force-pushed
the
doc-level-bug-bash
branch
from
80b2624
to
19cc3ba
Compare
lezzago
approved these changes
May 17, 2022
adityaj1107
approved these changes
May 18, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 18, 2022
* Renamed FindingsDashboard/utils to FindingsDashboard/findingsUtils for clarity. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed an unused helper method. Refactored various helper methods to have default values. Refactored validation logic for doc level queries. Implemented unit tests for various doc level monitor functions. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented FindingPopover snapshot test. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented FindingFlyout snapshot test. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored DocumentLevelTriggerExpression to require selections, and removed redundant code. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implementing integration tests Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented an example trigger condition for doc level monitors that are defined using the extraction query editor. Implemented additional form-reset logic when changing monitor types. Moved getDefaultScript to a separate helper class, and refactored the unit tests, to accommodate other monitor types. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored actions component for doc level monitors to support configuration action execution options. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored actions component to refresh the list of channels on blur. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a bug that was causing the finding flyout triggered by the alerts table to allow multiple flyouts to be open at once. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed development comment. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a bug that prevented sorting the performance preview for doc level monitors defined with the visual editor. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a bug that allowed doc level monitors to be defined with blank queries/tags when using the visual editor. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored the backend formatting used for 'is not' queries. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented additional integration tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored the default notify option for doc level monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed index creation step from test as ingesting data will perform that automatically. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 0434b4f)
AWSHurneyt
added a commit
that referenced
this pull request
May 18, 2022
* Renamed FindingsDashboard/utils to FindingsDashboard/findingsUtils for clarity. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed an unused helper method. Refactored various helper methods to have default values. Refactored validation logic for doc level queries. Implemented unit tests for various doc level monitor functions. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented FindingPopover snapshot test. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented FindingFlyout snapshot test. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored DocumentLevelTriggerExpression to require selections, and removed redundant code. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implementing integration tests Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented an example trigger condition for doc level monitors that are defined using the extraction query editor. Implemented additional form-reset logic when changing monitor types. Moved getDefaultScript to a separate helper class, and refactored the unit tests, to accommodate other monitor types. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored actions component for doc level monitors to support configuration action execution options. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored actions component to refresh the list of channels on blur. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a bug that was causing the finding flyout triggered by the alerts table to allow multiple flyouts to be open at once. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed development comment. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a bug that prevented sorting the performance preview for doc level monitors defined with the visual editor. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a bug that allowed doc level monitors to be defined with blank queries/tags when using the visual editor. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored the backend formatting used for 'is not' queries. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented additional integration tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored the default notify option for doc level monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed index creation step from test as ingesting data will perform that automatically. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 0434b4f) Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
added a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Jun 10, 2022
…-project#240) (opensearch-project#245) * Renamed FindingsDashboard/utils to FindingsDashboard/findingsUtils for clarity. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed an unused helper method. Refactored various helper methods to have default values. Refactored validation logic for doc level queries. Implemented unit tests for various doc level monitor functions. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented FindingPopover snapshot test. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented FindingFlyout snapshot test. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored DocumentLevelTriggerExpression to require selections, and removed redundant code. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implementing integration tests Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented an example trigger condition for doc level monitors that are defined using the extraction query editor. Implemented additional form-reset logic when changing monitor types. Moved getDefaultScript to a separate helper class, and refactored the unit tests, to accommodate other monitor types. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored actions component for doc level monitors to support configuration action execution options. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored actions component to refresh the list of channels on blur. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a bug that was causing the finding flyout triggered by the alerts table to allow multiple flyouts to be open at once. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed development comment. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a bug that prevented sorting the performance preview for doc level monitors defined with the visual editor. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a bug that allowed doc level monitors to be defined with blank queries/tags when using the visual editor. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored the backend formatting used for 'is not' queries. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented additional integration tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored the default notify option for doc level monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed index creation step from test as ingesting data will perform that automatically. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 0434b4f) Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.