Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements #345

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Minor improvements #345

merged 2 commits into from
Apr 25, 2022

Conversation

thalurur
Copy link
Contributor

Signed-off-by: Ravi Thaluru thalurur@users.noreply.github.com

Issue #, if available:
N/A

Description of changes:

  1. Porting additional check in rollover step that is missing
  2. Minor optimization, converting all retrieved matching indices to set for a more faster lookup when processing delete event in Coordinator
  3. Updating schema version - to force all changes going forward to be applied everywhere

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@thalurur thalurur requested a review from a team April 25, 2022 17:31
…b 2. Minor optimization, converting to set 3. Updating schema version

Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

Merging #345 (4f0d933) into main (534bb10) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #345      +/-   ##
============================================
- Coverage     75.25%   75.20%   -0.06%     
+ Complexity     2144     2142       -2     
============================================
  Files           262      262              
  Lines         12444    12444              
  Branches       1966     1966              
============================================
- Hits           9365     9358       -7     
- Misses         2012     2015       +3     
- Partials       1067     1071       +4     
Impacted Files Coverage Δ
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 75.22% <100.00%> (ø)
...anagement/indexstatemanagement/model/Transition.kt 63.01% <0.00%> (-2.74%) ⬇️
.../rollup/action/start/TransportStartRollupAction.kt 72.94% <0.00%> (-2.36%) ⬇️
...gement/indexstatemanagement/action/ShrinkAction.kt 70.58% <0.00%> (-1.48%) ⬇️
...earch/indexmanagement/transform/TransformRunner.kt 78.01% <0.00%> (-0.71%) ⬇️
...earch/indexmanagement/transform/model/Transform.kt 85.47% <0.00%> (-0.43%) ⬇️
.../opensearch/indexmanagement/rollup/model/Rollup.kt 86.04% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534bb10...4f0d933. Read the comment docs.

bowenlan-amzn
bowenlan-amzn previously approved these changes Apr 25, 2022
Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
@thalurur thalurur merged commit a7fd6c4 into opensearch-project:main Apr 25, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 25, 2022
Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
(cherry picked from commit a7fd6c4)
thalurur added a commit that referenced this pull request Apr 25, 2022
Signed-off-by: Ravi Thaluru <6005951+thalurur@users.noreply.github.com>
thalurur added a commit that referenced this pull request May 9, 2022
Signed-off-by: Ravi Thaluru <6005951+thalurur@users.noreply.github.com>
bowenlan-amzn pushed a commit to bowenlan-amzn/index-management that referenced this pull request May 10, 2022
Signed-off-by: Ravi <6005951+thalurur@users.noreply.github.com>
thalurur pushed a commit that referenced this pull request May 11, 2022
Signed-off-by: Ravi Thaluru <6005951+thalurur@users.noreply.github.com>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants