tune model config: change pooling mode to optional #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #724 +/- ##
=========================================
Coverage 84.95% 84.95%
Complexity 1076 1076
=========================================
Files 100 100
Lines 3922 3922
Branches 370 370
=========================================
Hits 3332 3332
Misses 433 433
Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dhrubo-os
reviewed
Feb 6, 2023
...arch/ml/engine/algorithms/text_embedding/ONNXSentenceTransformerTextEmbeddingTranslator.java
Show resolved
Hide resolved
dhrubo-os
approved these changes
Feb 6, 2023
Zhangxunmt
approved these changes
Feb 6, 2023
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Feb 17, 2023
…t#724) Signed-off-by: Yaliang Wu <ylwu@amazon.com>
model-collapse
pushed a commit
that referenced
this pull request
Feb 20, 2023
…in (#711) * [wjunshen] #N/A feat: fix after the latest rebase Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: fix after rebase Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: fix after rebase Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: fix after rebase Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: fix after the latest rebase Signed-off-by: wujunshen <frank_wjs@hotmail.com> * Increment version to 2.6.0-SNAPSHOT (#671) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: wujunshen <frank_wjs@hotmail.com> * fix profile API in example doc (#712) Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: wujunshen <frank_wjs@hotmail.com> * change model url to public repo in text embedding model example doc (#713) Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: wujunshen <frank_wjs@hotmail.com> * Enhance profile API to add model centric result controlled by view parameter (#714) * Enhance profile API to add model centric result controled by view paramter Signed-off-by: Zan Niu <zaniu@amazon.com> * Enhance profile API to add model centric result controled by view parameter Signed-off-by: Zan Niu <zaniu@amazon.com> * Enhance profile API to add model centric result controled by view parameter Signed-off-by: Zan Niu <zaniu@amazon.com> --------- Signed-off-by: Zan Niu <zaniu@amazon.com> Signed-off-by: wujunshen <frank_wjs@hotmail.com> * add planning work nodes to model (#715) * add planning work nodes to model Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add test Signed-off-by: Yaliang Wu <ylwu@amazon.com> --------- Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: wujunshen <frank_wjs@hotmail.com> * skip running syncup job if no model index (#717) Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: wujunshen <frank_wjs@hotmail.com> * refactor: add DL model class (#722) * refactor: add DL model class Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix model url in example doc Signed-off-by: Yaliang Wu <ylwu@amazon.com> * address comments Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix failed ut Signed-off-by: Yaliang Wu <ylwu@amazon.com> --------- Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: wujunshen <frank_wjs@hotmail.com> * tune model config: change pooling mode to optional (#724) Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: make the log readable Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: add error log Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: Refer to PR #717,just checking if index exists in cluster metadata Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: change RunTimeException to MLException Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: also consider COMPLETED_WITH_ERROR Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: remove ML_MODEL_RELOAD_MAX_RETRY_TIMES in CommonValue.java Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: remove Result class Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: change "reload" and "retry" to a full word Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: change log info sentence Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [wjunshen] #N/A feat: code format Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [Signed-off-by: wjunshen<wjunshen@amazon.com>] #N/A feat: 1. Let the collection just have all ids of ml node 2. print out full exception stack trace Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [Signed-off-by: wjunshen<wjunshen@amazon.com>] #N/A feat: use LOAD_THREAD_POOL to replace generic Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [Signed-off-by: wjunshen<wjunshen@amazon.com>] #N/A feat: print the whole exception stack Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [Signed-off-by: wjunshen<wjunshen@amazon.com>] #N/A feat: change the IndexNotFoundException to MLException Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [Signed-off-by: wjunshen<wjunshen@amazon.com>] #N/A feat: add logs when receiving indexRequestBuilder.execute exception Signed-off-by: wujunshen <frank_wjs@hotmail.com> * [Signed-off-by: wjunshen<wjunshen@amazon.com>] #N/A feat: change the test code after code review Signed-off-by: wujunshen <frank_wjs@hotmail.com> --------- Signed-off-by: wujunshen <frank_wjs@hotmail.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Zan Niu <zaniu@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Yaliang Wu <ylwu@amazon.com> Co-authored-by: zane-neo <zaniu@amazon.com>
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Mar 3, 2023
…t#724) Signed-off-by: Yaliang Wu <ylwu@amazon.com>
5 tasks
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Mar 4, 2023
…t#724) Signed-off-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn
added a commit
that referenced
this pull request
Mar 4, 2023
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yaliang Wu ylwu@amazon.com
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.