set value required in constant_keyword field type

[kkewwei]

Description

set value required in constant_keyword field type

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Changes Analysis

Commit SHA: 4762fd2
Comparing To SHA: 6627ca7

API Changes

Summary

└─┬Components
  └─┬_common.mapping:ConstantKeywordProperty
    └─┬ALLOF
      ├──[➕] required (33544:15)❌ 
      └─┬value
        └──[🔀] type (33537:21)❌ 

Document Element	Total Changes	Breaking Changes
components	2	4

• ❌ BREAKING Changes: 4 out of 2
• Modifications: 1
• Additions: 1
• Breaking Modifications: 1
• Breaking Additions: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9975458337/artifacts/1711030412

API Coverage

	Before	After	Δ
Covered (%)	483 (47.31 %)	483 (47.31 %)	0 (0 %)
Uncovered (%)	538 (52.69 %)	538 (52.69 %)	0 (0 %)
Unknown	24	24	0

[dblock]

Looks like tests are failing.

Organization-wise I wonder where we should put this test. Is this a _doc or mapping thing? Maybe we want to create subfolders accordingly under tests? WDYT?

[dblock]

Looks like 2.0 test failed. Which version was this added in? You will need a version: '>= ...' in the test.

Also add a line to CHANGELOG. This is a fix for the constant_keyword mapping type.

[dblock]

One nit for CHANGELOG.

The 2.16 daily is failing to startup, I'll look into it.

https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9967302688/job/27562098545

[kkewwei]

@dblock, The source code has the bug( opensearch-project/OpenSearch#14651), is this caused by the bug?

[dblock]

@dblock, The source code has the bug( opensearch-project/OpenSearch#14651), is this caused by the bug?

Dailies don't have all plugins when they fail to build, looks like today security plugin didn't work, so the version on docker hub doesn't have security/SSL, and that's what's failing. I locked it to a specific revision in #431 and we can update it regularly.

[dblock]

Merging since the 2.16 problem is unrelated. Thanks @kkewwei!

[dblock]

@kkewwei Did I make a mistake merging this? This test is not supposed to work in 2.15 either because of opensearch-project/OpenSearch#14651 and we have to wait for your fix to be merged there? I can revert.

[dblock]

@kkewwei Reopen this when the bug is fixed with >= 2.16 (will need an update of the first image that has the fix in https://github.com/opensearch-project/opensearch-api-specification/blob/main/.github/workflows/test-spec.yml#L29).