Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "set value required in constant_keyword field type" #432

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jul 17, 2024

Reverts #419

Merged too fast. The fix opensearch-project/OpenSearch#14651 has not been merged.

@kkewwei am I understanding this correctly? In which case reopen your PR in draft and mark the test >= 2.16?

This reverts commit 7e1a233.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the revert-419-constant_keyword branch from 7f9324b to 92f875d Compare July 17, 2024 14:49
Copy link

github-actions bot commented Jul 17, 2024

Changes Analysis

Commit SHA: 92f875d
Comparing To SHA: 7e1a233

API Changes

Summary

└─┬Components
  └─┬_common.mapping:ConstantKeywordProperty
    └─┬ALLOF
      ├──[➖] required (33544:15)❌ 
      └─┬value
        └──[🔀] type (33537:21)❌ 

Document Element Total Changes Breaking Changes
components 2 4
  • BREAKING Changes: 4 out of 2
  • Modifications: 1
  • Removals: 1
  • Breaking Removals: 1
  • Breaking Modifications: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9976470956/artifacts/1711203247

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@kkewwei
Copy link
Contributor

kkewwei commented Jul 17, 2024

@dblock constant_keyword is introduced in 2.14(https://opensearch.org/docs/2.14/field-types/supported-field-types/constant-keyword/), and it has bug, I don't know if I answered your question.

@dblock
Copy link
Member Author

dblock commented Jul 17, 2024

@dblock constant_keyword is introduced in 2.14(https://opensearch.org/docs/2.14/field-types/supported-field-types/constant-keyword/), and it has bug, I don't know if I answered your question.

Does this feature work at all in >= 2.14?

This fails for me in 2.14 with a timeout (and a server-side error that looks like opensearch-project/OpenSearch#14651), so I think the right thing to do is to revert these tests. We can merge them when the bug is fixed.

ERROR   constant_keyword.yaml (/Users/dblock/source/opensearch-project/opensearch-api-specification/dblock-opensearch-api-specification/tests/mapping/constant_keyword.yaml)
    PASSED  PROLOGUES
        PASSED  PUT /movies
    ERROR   CHAPTERS
        ERROR   Create a document.
            PASSED  PARAMETERS
                PASSED  index
            PASSED  REQUEST BODY
            ERROR   RESPONSE STATUS (Expected status 201, but received 503: application/json. [movies][0] primary shard is not active Timeout: [1m], request: [BulkShardRequest [[movies][0]] containing [index {[movies][jk5xwZABmSqzi6U2Pv_V], source[{"genre":"Romantic comedy","year":1991}]}]])
            SKIPPED RESPONSE PAYLOAD BODY
            SKIPPED RESPONSE PAYLOAD SCHEMA
    PASSED  EPILOGUES
        PASSED  DELETE /movies

@nhtruong nhtruong merged commit 82c000f into main Jul 17, 2024
19 checks passed
@nhtruong nhtruong deleted the revert-419-constant_keyword branch July 17, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants