Fix permissions for github release #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
=======================================
Coverage 88.69% 88.69%
=======================================
Files 68 68
Lines 3778 3778
=======================================
Hits 3351 3351
Misses 427 427
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AndreKurait
force-pushed
the
FixReleaseDockerPublish
branch
2 times, most recently
from
3f6e6d4
to
82f635c
Compare
AndreKurait
requested review from
chelma,
gregschohn,
lewijacn,
mikaylathompson,
okhasawn,
peternied and
sumobrian
as code owners
mikaylathompson
approved these changes
Aug 6, 2024
| @@ -12,6 +12,7 @@ env: | |||
| permissions: | |||
| id-token: write | |||
| contents: read | |||
| issues: write | |||
There was a problem hiding this comment.
Is write a superset of read & write? Presumably we need to do both, right?
There was a problem hiding this comment.
Write is what they actually have in their readme to use
Signed-off-by: Andre Kurait <akurait@amazon.com>
Signed-off-by: Andre Kurait <akurait@amazon.com>
AndreKurait
force-pushed
the
FixReleaseDockerPublish
branch
from
82f635c
to
a3c033b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes github actions for release, the release workflow needed issue permission.
Fixes AndreKurait maintainer (the approval workflow is case sensitive)
Issues Resolved
MIGRATIONS-1570
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Tested in github actions by triggering workflow, was not able to test anything with assuming the role and after since it requires to be cut on the tag.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.