Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permissions for github release #871

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Fix permissions for github release #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57fa5ab
Fix AndreKurait codeowners
AndreKurait Aug 6, 2024
a3c033b
Fix Aws Credentials Assume role
AndreKurait Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# This should match the owning team set up in https://github.com/orgs/opensearch-project/teams
* @andrekurait @chelma @gregschohn @lewijacn @mikaylathompson @okhasawn @peternied @sumobrian
* @AndreKurait @chelma @gregschohn @lewijacn @mikaylathompson @okhasawn @peternied @sumobrian
4 changes: 3 additions & 1 deletion .github/workflows/release-drafter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ env:
permissions:
id-token: write
contents: read
issues: write
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is write a superset of read & write? Presumably we need to do both, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write is what they actually have in their readme to use


jobs:
draft-a-release:
Expand Down Expand Up @@ -55,7 +56,8 @@ jobs:
docker tag migrations/traffic_replayer:latest opensearchstaging/opensearch-migrations-traffic-replayer:${{ steps.get_data.outputs.version }}
docker tag migrations/capture_proxy:latest opensearchstaging/opensearch-migrations-traffic-capture-proxy:${{ steps.get_data.outputs.version }}
docker tag migrations/reindex_from_snapshot:latest opensearchstaging/opensearch-migrations-reindex-from-snapshot:${{ steps.get_data.outputs.version }}
- uses: aws-actions/configure-aws-credentials@v4
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ secrets.MIGRATIONS_DOCKER_ROLE }}
aws-region: us-east-1
Expand Down
20 changes: 10 additions & 10 deletions MAINTAINERS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@ This document contains a list of maintainers in this repo. See [opensearch-proje

## Current Maintainers

| Maintainer | GitHub ID | Affiliation |
| ------------------ | ------------------------------------------------------- | ----------- |
| Chris Helma | [chelma](https://github.com/chelma) | Amazon |
| Greg Schohn | [gregschohn](https://github.com/gregschohn) | Amazon |
| Tanner Lewis | [lewijacn](https://github.com/lewijacn) | Amazon |
| Mikayla Thompson | [mikaylathompson](https://github.com/mikaylathompson) | Amazon |
| Omar Khasawneh | [okhasawn](https://github.com/okhasawn) | Amazon |
| Brian Presley | [sumobrian](https://github.com/sumobrian) | Amazon |
| Andre Kurait | [andrekurait](https://github.com/andrekurait) | Amazon |
| Peter Nied | [peternied](https://github.com/peternied) | Amazon |
| Maintainer | GitHub ID | Affiliation |
| ------------------ |-------------------------------------------------------| ----------- |
| Chris Helma | [chelma](https://github.com/chelma) | Amazon |
| Greg Schohn | [gregschohn](https://github.com/gregschohn) | Amazon |
| Tanner Lewis | [lewijacn](https://github.com/lewijacn) | Amazon |
| Mikayla Thompson | [mikaylathompson](https://github.com/mikaylathompson) | Amazon |
| Omar Khasawneh | [okhasawn](https://github.com/okhasawn) | Amazon |
| Brian Presley | [sumobrian](https://github.com/sumobrian) | Amazon |
| Andre Kurait | [andrekurait](https://github.com/AndreKurait) | Amazon |
| Peter Nied | [peternied](https://github.com/peternied) | Amazon |


## Emeritus
Expand Down