Fix rpm build by adding config to env variable #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzane17
previously approved these changes
Apr 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
============================================
- Coverage 71.93% 71.77% -0.16%
+ Complexity 368 367 -1
============================================
Files 44 44
Lines 2519 2519
Branches 169 169
============================================
- Hits 1812 1808 -4
- Misses 595 598 +3
- Partials 112 113 +1
Continue to review full report at Codecov.
|
This was referenced Apr 27, 2022
sgup432
reviewed
Apr 27, 2022
packaging/rpm/postinst
Outdated
| echo '## OpenSearch Performance Analyzer' >> $OPENSEARCH_PATH_CONF/jvm.options | ||
| echo "-Dclk.tck=$CLK_TCK" >> $OPENSEARCH_PATH_CONF/jvm.options | ||
| echo "-Djdk.attach.allowAttachSelf=true" >> $OPENSEARCH_PATH_CONF/jvm.options | ||
| echo "-Djava.security.policy=file:///etc/opensearch/opensearch-performance-analyzer/opensearch_security.policy" >> $OPENSEARCH_PATH_CONF/jvm.options |
There was a problem hiding this comment.
/etc/opensearch/opensearc-performance/.... -> $OPENSEARCH_PATH_CONF/opensearch-performance-analyzer... ?
packaging/deb/postinst
Outdated
| echo '## OpenSearch Performance Analyzer' >> $OPENSEARCH_PATH_CONF/jvm.options | ||
| echo "-Dclk.tck=$CLK_TCK" >> $OPENSEARCH_PATH_CONF/jvm.options | ||
| echo "-Djdk.attach.allowAttachSelf=true" >> $OPENSEARCH_PATH_CONF/jvm.options | ||
| echo "-Djava.security.policy=file:///etc/opensearch/opensearch-performance-analyzer/opensearch_security.policy" >> $OPENSEARCH_PATH_CONF/jvm.options |
There was a problem hiding this comment.
Why leave one /etc/opensearch out with hardcoding?
Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
sruti1312
force-pushed
the
feature/fix-rpm
branch
from
cad4515
to
ced2dea
Compare
sgup432
approved these changes
Apr 27, 2022
dzane17
approved these changes
Apr 27, 2022
sruti1312
added a commit
that referenced
this pull request
Apr 28, 2022
* Adding release notes for 2.0.0-rc1 (#193) Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Updating release notes for 2.0.0-rc1 (#196) Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Fix rpm build (#200) Signed-off-by: sruti1312 <srutiparthiban@gmail.com> Co-authored-by: Sagar <99425694+sgup432@users.noreply.github.com>
sruti1312
added a commit
that referenced
this pull request
May 11, 2022
Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
sruti1312
added a commit
that referenced
this pull request
May 16, 2022
* Update directory names and remove jar for integTest Signed-off-by: sruti1312 <srutiparthiban@gmail.com> * Fix rpm build (#200) Signed-off-by: sruti1312 <srutiparthiban@gmail.com> * Add env var check during installation (#206) Signed-off-by: sruti1312 <srutiparthiban@gmail.com> * Update PA directories from plugins to root Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sruti1312 srutiparthiban@gmail.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#197
Describe the solution you are proposing
Adds config location to env variable
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.