Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env var check during installation #206

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Conversation

sruti1312
Copy link
Contributor

@sruti1312 sruti1312 commented Apr 28, 2022

Signed-off-by: sruti1312 srutiparthiban@gmail.com

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you are proposing
Add env var check during installation

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
@sruti1312 sruti1312 requested review from a team, dzane17 and sgup432 April 28, 2022 21:14
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #206 (7deba50) into main (bd0b4ce) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #206      +/-   ##
============================================
- Coverage     71.93%   71.77%   -0.16%     
+ Complexity      368      367       -1     
============================================
  Files            44       44              
  Lines          2519     2519              
  Branches        169      169              
============================================
- Hits           1812     1808       -4     
- Misses          595      598       +3     
- Partials        112      113       +1     
Impacted Files Coverage Δ
...ormanceanalyzer/writer/EventLogQueueProcessor.java 55.95% <0.00%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd0b4ce...7deba50. Read the comment docs.

@sruti1312 sruti1312 merged commit 5105221 into main Apr 28, 2022
@sruti1312 sruti1312 deleted the feature/add-env-check branch April 28, 2022 21:38
sruti1312 added a commit that referenced this pull request May 11, 2022
Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
sruti1312 added a commit that referenced this pull request May 16, 2022
* Update directory names and remove jar for integTest

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>

* Fix rpm build (#200)

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>

* Add env var check during installation (#206)

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>

* Update PA directories from plugins to root

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants