Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Enable CI Workflows to Re-use Setup Steps #1156

Closed
cliu123 opened this issue Oct 25, 2022 · 4 comments · Fixed by #1212
Closed

[Maintenance] Enable CI Workflows to Re-use Setup Steps #1156

cliu123 opened this issue Oct 25, 2022 · 4 comments · Fixed by #1212
Labels
enhancement New feature or request triaged

Comments

@cliu123
Copy link
Member

cliu123 commented Oct 25, 2022

Is your request related to a problem?

The request comes from a PR review comment.

What solution would you like?

The request is about enabling different CI workflows to re-use the setup steps.

What alternatives have you considered?
No alternatives for now.

Do you have any additional context?
Github does not have reusable jobs at all. It has reusable workflow instead. But in order to re-use those setup steps, the steps need to be reusable.

@cwperks
Copy link
Member

cwperks commented Oct 31, 2022

[Triage] @RyanL1997 Can you please update the issue with your findings?

@cwperks cwperks added triaged and removed untriaged labels Oct 31, 2022
@stephen-crawford
Copy link
Collaborator

Is this info helpful? https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts

@RyanL1997
Copy link
Collaborator

I have tried to build a reusable workflow for core setup (https://github.com/RyanL1997/security-dashboards-plugin/actions/runs/3330166123). Even the workflow can be reused, we cannot pass the up running server through the workflow.

@peternied
Copy link
Member

peternied commented Nov 2, 2022

@RyanL1997 you are right dependent workflows won't work

However, I think action [1] will provide this functionality, I recently merged a change that uses one of these composite actions for the dashboard checkout process [2].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged
Projects
None yet
5 participants